Fix mpris bugs - follows #480 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-fix missing songControls
-use player.seeked directly
-fix 'seeked' event listener
-fix e.target instead of e.detail in apiLoaded event
-fix document.querySelector('video') before apiLoaded
-setup timeChange Listener if linux+shortcuts enabled
Araxeus
changed the title
th-ch
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sadly couldn't test the changes on linux after the latest merge conflict solving on PR #480 since I use windows, and some stupid bugs made their way to the main branch because of that.
Thankfully @JoeJoeTV helped test mpris on linux once again, and all the little bugs have been fixed in this PR
Sorry about those!
-fix missing songControls (forgot to re-add it after moving the code from
shortcuts/back.jstoshortcuts/mpris.js🤦🏼♂️)-fix e.target instead of e.detail in apiLoaded event (to access the api)
-fix document.querySelector('video') being called before apiLoaded
-fix 'seeked' event listener
-setup timeChange Listener if on linux+shortcuts enabled
(I also added a sneaky change to the youtube-music.css that hides the chromecast button which doesn't work because electron doesn't support[1][2] the
chrome.castapi)