Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce menu roles for macOS Sierra tabs #9086

Closed
bpasero opened this issue Apr 2, 2017 · 1 comment
Closed

Introduce menu roles for macOS Sierra tabs #9086

bpasero opened this issue Apr 2, 2017 · 1 comment
Labels
component/menu enhancement ✨ platform/macOS

Comments

@bpasero
Copy link
Contributor

bpasero commented Apr 2, 2017 •
edited
Loading

After #9052 landed and you can enable native macOS sierra tabs in Electron apps it would be nice if as an application I could control where this menu item goes to:

image

My understanding is that a menu item role could help here? That way I would add a menu item to the desired location with that role and not have it show up as first entry without much control from the application itself.

/cc @tonyganch
@bpasero
Copy link
Contributor Author

bpasero commented Apr 3, 2017

Actually there seems to be more roles for tab management we should expose:

image

@bpasero bpasero changed the title Have a role for menu item "Show Tab Bar" Introduce menu roles for macOS Sierra tabs Apr 3, 2017
@bpasero bpasero mentioned this issue May 5, 2017
Closed
kaylanm added a commit to kaylanm/electron that referenced this issue Aug 15, 2017
@kaylanm
🍎 Add roles for macOS native tab menu items
7741a0e 
Fixes electron#9086, electron#10064.
@kaylanm kaylanm mentioned this issue Aug 15, 2017
Merged
kaylanm added a commit to kaylanm/electron that referenced this issue Sep 16, 2017
@kaylanm
🍎 Add roles for macOS native tab menu items
f84b768 
Fixes electron#9086, electron#10064.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/menu enhancement ✨ platform/macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinsawicki @bpasero