New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter descriptions for common accept types #10015

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Jul 14, 2017

This pulls in some code from https://cs.chromium.org/chromium/src/chrome/browser/file_select_helper.cc?l=366 to add a open dialog filter description for the common accept types when doing something like:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
  </head>
  <body>
    <input type="file" name="pic" accept="image/*">
  </body>
</html>

Noticed this while comparing Chrome and Electron input file dialog behavior while reviewing #9745

Before After
screen shot 2017-07-14 at 11 33 44 am screen shot 2017-07-14 at 11 06 42 am

@kevinsawicki kevinsawicki merged commit 2bac358 into master Jul 18, 2017

8 of 9 checks passed

electron-osx-x64 Build #4578 failed in 10 min
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #7294223 succeeded in 102s
Details
electron-linux-ia32 Build #7294224 succeeded in 93s
Details
electron-linux-x64 Build #7294225 succeeded in 212s
Details
electron-mas-x64 Build #4577 succeeded in 10 min
Details
electron-win-ia32 Build #3561 succeeded in 11 min
Details
electron-win-x64 Build #3553 succeeded in 11 min
Details

@kevinsawicki kevinsawicki deleted the input-dialog-filter-titles branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment