New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter descriptions for common accept types #10015

Merged

kevinsawicki merged 1 commit into master from input-dialog-filter-titles

Jul 18, 2017

Contributor

kevinsawicki commented Jul 14, 2017

This pulls in some code from https://cs.chromium.org/chromium/src/chrome/browser/file_select_helper.cc?l=366 to add a open dialog filter description for the common accept types when doing something like:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
  </head>
  <body>
    <input type="file" name="pic" accept="image/*">
  </body>
</html>

Noticed this while comparing Chrome and Electron input file dialog behavior while reviewing #9745

Before	After


          Add filter descriptions for common accept types

c495613

kevinsawicki merged commit 2bac358 into master

kevinsawicki deleted the input-dialog-filter-titles branch

July 18, 2017 16:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet