Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty string when fs.readFile with 'utf8' option from asar file #10160

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Return empty string when fs.readFile with 'utf8' option from asar file #10160

merged 2 commits into from
Aug 8, 2017

Conversation

liusy182
Copy link
Contributor

fixes #10128

@liusy182 liusy182 changed the title fixes 10128 Return empty string when fs.readFile with 'utf8' option from asar file Jul 31, 2017
@codebytere codebytere self-requested a review August 1, 2017 05:48
@codebytere
Copy link
Member

codebytere commented Aug 1, 2017 •
edited
Loading

heyo! looks great, thanks for this fix! just run npm run lint on this, i see potential issues on asar.js:482:34 & on asar.js:489:1

codebytere
codebytere approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both those CI builds are a little flaky so that's not your fault. Good to go!

@jkleinsc jkleinsc merged commit 72d2e17 into electron:master Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.readFile with 'utf8' option get an object when read an empty file in the ASAR
3 participants
@liusy182 @codebytere @jkleinsc