New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty string when fs.readFile with 'utf8' option from asar file #10160

Merged
merged 2 commits into from Aug 8, 2017

Conversation

Projects
None yet
3 participants
@liusy182
Contributor

liusy182 commented Jul 31, 2017

fixes #10128

@liusy182 liusy182 changed the title from fixes 10128 to Return empty string when fs.readFile with 'utf8' option from asar file Jul 31, 2017

@codebytere codebytere self-requested a review Aug 1, 2017

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Aug 1, 2017

Member

heyo! looks great, thanks for this fix! just run npm run lint on this, i see potential issues on asar.js:482:34 & on asar.js:489:1

Member

codebytere commented Aug 1, 2017

heyo! looks great, thanks for this fix! just run npm run lint on this, i see potential issues on asar.js:482:34 & on asar.js:489:1

@codebytere

Both those CI builds are a little flaky so that's not your fault. Good to go!

@jkleinsc jkleinsc merged commit 72d2e17 into electron:master Aug 8, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment