New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect dead link in docs #10481

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
2 participants
@John2143
Contributor

John2143 commented Sep 10, 2017

The link previous link exists in the wayback machine (http://web.archive.org/web/20151030063902/https://strongloop.com/strongblog/whats-new-node-js-v0-12-multiple-context-execution/), however on the live page the link is dead. This is the commit message for node that summarizes it well, but maybe the better option is just to remove the link entirely.

@welcome

This comment has been minimized.

welcome bot commented Sep 10, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@John2143 John2143 changed the title from :memo: Redirect dead link [ci skip] to Redirect dead link in docs Sep 10, 2017

@zeke zeke merged commit c51e3c2 into electron:master Sep 11, 2017

@zeke

This comment has been minimized.

Member

zeke commented Sep 11, 2017

Thanks!

@welcome

This comment has been minimized.

welcome bot commented Sep 11, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@John2143 John2143 deleted the John2143:fix-docs branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment