[WIP] add getMenuItemById to Menu API #10618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/browser/api/menu.js
Outdated
| @@ -189,6 +189,19 @@ Menu.prototype.closePopup = function (window) { | |||
| } | |||
| } | |||
|
|
|||
| Menu.prototype.getMenuItemById = function (id) { | |||
| let items = this | |||
| if (items instanceof Menu) items = this.items | |||
There was a problem hiding this comment.
I might be missing something, but why not go with this.items directly?
There was a problem hiding this comment.
oops, didn't update that from when i refactored to remove items as a parameter in favor of using this
MarshallOfSound
requested changes
Sep 27, 2017
lib/browser/api/menu.js
Outdated
| Menu.prototype.getMenuItemById = function (id) { | ||
| const items = this.items | ||
|
|
||
| let found = items.find(item => item.id === id) || false |
There was a problem hiding this comment.
Should probably default to null over false
MarshallOfSound
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature requested in #10440
Ability to fetch a menu items by passing in
MenuItems and anid.Called like:
const fsc = menu.getMenuItemById('fullScreen');