Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer sh to bash in the docs #11247

Merged
merged 3 commits into from
Nov 24, 2017
Merged

prefer sh to bash in the docs #11247

merged 3 commits into from
Nov 24, 2017

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Nov 24, 2017

Does what it says on the tin.

Not the most complicated patch in the world, more of a since-we're-in-the-neighborhood with all the documentation work and I keep seeing bash, I was reminded of this discussion with @zeke, @vanessayuenn and me on this topic

@ckerr ckerr requested a review from a team November 24, 2017 10:15
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for not letting this fall through the cracks!

@codebytere codebytere merged commit 6941f93 into master Nov 24, 2017
@codebytere codebytere deleted the use_sh_in_docs branch November 24, 2017 10:38
@zeke
Copy link
Contributor

zeke commented Nov 25, 2017

✨ 🐚 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants