Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Accept additional notification actions #11647

Merged
merged 11 commits into from
Feb 15, 2018
Merged

feat: Accept additional notification actions #11647

merged 11 commits into from
Feb 15, 2018

Commits on Feb 10, 2018

  1. Accept additional notification actions 

    Change to the existing API definition: The first action with type `button` seen will be displayed on the notification, the rest listed as additional actions (shown when holding down on the primary action button)
    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    844ee0a View commit details
    Browse the repository at this point in the history

  2. Fix include order

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    09d51f0 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    3ee3e9a View commit details
    Browse the repository at this point in the history

  4. NSUserNotification should respond 

    NSUserNotification is expected to responsd to `@selector(setContentImage:)` with macOS ^10.9
    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    31baafa View commit details
    Browse the repository at this point in the history

  5. Simplify formatting

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    1e1087a View commit details
    Browse the repository at this point in the history

  6. Use std::string::empty to check

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    75b990f View commit details
    Browse the repository at this point in the history

  7. Overload method for naming consistency

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    0b7a629 View commit details
    Browse the repository at this point in the history

  8. Update NotificationAction doc

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    69e65e0 View commit details
    Browse the repository at this point in the history

  9. Mention change of default value scenario in doc

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    bf11b09 View commit details
    Browse the repository at this point in the history

  10. Tweak wording

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    d05791c View commit details
    Browse the repository at this point in the history

  11. Fix grammar

    @sethlu
    sethlu committed Feb 10, 2018
    Configuration menu
    Copy the full SHA
    e3b70dd View commit details
    Browse the repository at this point in the history