Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance security documentation #11770

Merged
merged 20 commits into from
Jan 30, 2018
Merged

Enhance security documentation #11770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
601fbc8
:memo: Link to security tutorial
felixrieseberg Jan 29, 2018
2db1258
:memo: Secure content
felixrieseberg Jan 29, 2018
d67c64b
:memo: Disable Node Integration
felixrieseberg Jan 29, 2018
f790c24
:memo: Verify WebView creation
felixrieseberg Jan 29, 2018
a5c900a
:memo: Context Isolation
felixrieseberg Jan 29, 2018
c793ee3
:memo: Content Security Policy
felixrieseberg Jan 29, 2018
5418866
:memo: eval()
felixrieseberg Jan 29, 2018
e73f142
:memo: allowRunningInsecureContent
felixrieseberg Jan 29, 2018
39e0efd
:memo: Experimental Features
felixrieseberg Jan 29, 2018
7e79ae7
:memo: Blink Features
felixrieseberg Jan 29, 2018
cdb20d2
:wrench: WebSecurity
felixrieseberg Jan 29, 2018
4cb22dd
:memo: allowpopups
felixrieseberg Jan 29, 2018
c4dc8da
:memo: Context Isolation
felixrieseberg Jan 29, 2018
fb8606d
:memo: General cleanup
felixrieseberg Jan 29, 2018
536ff0b
:construction_worker: Fix failed test
felixrieseberg Jan 29, 2018
8804b09
:heart: Implement @zeke’s feedback
felixrieseberg Jan 29, 2018
8f685e9
:construction_worker: Linter errors
felixrieseberg Jan 29, 2018
1e1729a
:heart: More feedback
felixrieseberg Jan 30, 2018
d8d19ba
:heart: Even more feedback
felixrieseberg Jan 30, 2018
93dc38a
:construction_worker: Put ESLint's mind at ease
felixrieseberg Jan 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions SECURITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ To report a security issue, email [electron@github.com](mailto:electron@github.c
The Electron team will send a response indicating the next steps in handling your report. After the initial reply to your report, the security team will keep you informed of the progress towards a fix and full announcement, and may ask for additional information or guidance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really useful to have a time limit here, like "The team will respond in 48 hours to confirm that someone has seen your message. If you do not get a response, do X."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be useful, but no such policy exists right now and it would need to go through the maintainers group, so no need to block this PR on it. @diracdeltas you may want to open a separate issue for that suggestion.


Report security bugs in third-party modules to the person or team maintaining the module. You can also report a vulnerability through the [Node Security Project](https://nodesecurity.io/report).

## Learning More About Security
To learn more about securing an Electron application, please see the [security tutorial](docs/tutorial/security.md).
Loading