New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcc on 1-8-x to include a backport fix #12151

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@zcbenz
Contributor

zcbenz commented Mar 7, 2018

Update libcc for electron/libchromiumcontent#469, which is a mips64el only patch.

@zcbenz zcbenz requested review from electron/docs as code owners Mar 7, 2018

@zcbenz zcbenz changed the base branch from master to 1-8-x Mar 7, 2018

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Mar 7, 2018

The failing test are the usual flaky ones, the change itself is fine.

@ckerr

ckerr approved these changes Mar 7, 2018

@ckerr ckerr merged commit 8efd31a into 1-8-x Mar 7, 2018

7 of 9 checks passed

jenkins: arm64/pr-head This commit cannot be built
Details
jenkins: macOS/pr-head This commit cannot be built
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zcbenz zcbenz deleted the mips64el-patch-1-8-x branch Mar 7, 2018

@release-notifier

This comment has been minimized.

release-notifier bot commented Mar 16, 2018

This PR landed in electron v1.8.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment