New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remote setInterval flake (1.8.x) #12266

Merged
merged 1 commit into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Mar 14, 2018

backport of #12263

@MarshallOfSound MarshallOfSound requested a review from ckerr Mar 14, 2018

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Mar 14, 2018

@MarshallOfSound MarshallOfSound changed the title from fix remote setInterval flake to fix remote setInterval flake (1.8.x) Mar 14, 2018

@ckerr

ckerr approved these changes Mar 14, 2018

👍

@ckerr ckerr merged commit e2c7b43 into 1-8-x Mar 14, 2018

9 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-mips64el Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins: arm64/pr-head This commit looks good
Details

@ckerr ckerr deleted the cherry-pick-flake-1-8 branch Mar 14, 2018

@release-notifier

This comment has been minimized.

release-notifier bot commented Mar 16, 2018

This PR landed in electron v1.8.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment