Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remote setInterval flake (1.8.x) #12266

Merged
merged 1 commit into from
Mar 14, 2018
Merged

fix remote setInterval flake (1.8.x) #12266

merged 1 commit into from
Mar 14, 2018

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Mar 14, 2018 •
edited
Loading

backport of #12263

@MarshallOfSound MarshallOfSound requested review from ckerr and a team March 14, 2018 06:01
@MarshallOfSound MarshallOfSound added the backport This is a backport PR label Mar 14, 2018
@MarshallOfSound MarshallOfSound changed the title fix remote setInterval flake fix remote setInterval flake (1.8.x) Mar 14, 2018
ckerr
ckerr approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ckerr ckerr merged commit e2c7b43 into 1-8-x Mar 14, 2018
@ckerr ckerr deleted the cherry-pick-flake-1-8 branch March 14, 2018 06:42
@release-notifier
Copy link

This PR landed in electron v1.8.4 🎉

This was referenced Mar 16, 2018
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @ckerr