New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the default of allowRunningInsecureContent as per docs #12556

Merged
merged 3 commits into from Apr 16, 2018

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Apr 6, 2018

Fixes #12555

@MarshallOfSound MarshallOfSound requested a review from ckerr Apr 6, 2018

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Apr 6, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Apr 15, 2018

Member

Failing on

../../atom/browser/web_contents_preferences.cc:71:23: error: no member named 'GetBoolean' in 'mate::Dictionary'
  if (web_preferences.GetBoolean("webSecurity", &webSecurity) && !webSecurity) {
      ~~~~~~~~~~~~~~~ ^
Member

codebytere commented Apr 15, 2018

Failing on

../../atom/browser/web_contents_preferences.cc:71:23: error: no member named 'GetBoolean' in 'mate::Dictionary'
  if (web_preferences.GetBoolean("webSecurity", &webSecurity) && !webSecurity) {
      ~~~~~~~~~~~~~~~ ^
@ckerr

ckerr approved these changes Apr 16, 2018

👍

@ckerr ckerr merged commit d06c79f into master Apr 16, 2018

8 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 16, 2018

An error occurred while attempting to backport this PR to "1-7-x", you will need to perform this backport manually

trop bot commented Apr 16, 2018

An error occurred while attempting to backport this PR to "1-7-x", you will need to perform this backport manually

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 16, 2018

We have automatically backported this PR to "2-0-x", please check out #12629

trop bot commented Apr 16, 2018

We have automatically backported this PR to "2-0-x", please check out #12629

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Apr 16, 2018

We have automatically backported this PR to "1-8-x", please check out #12630

trop bot commented Apr 16, 2018

We have automatically backported this PR to "1-8-x", please check out #12630

@trop trop bot added merged/1-8-x and removed target/1-8-x labels Apr 16, 2018

@ckerr ckerr deleted the insecure-default branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment