docs: clarify default auto-updater installation behavior #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/api/auto-updater.md
Outdated
| **Note:** It is not strictly necessary to call this function to apply an update, | ||
| as a successfully downloaded update will always be applied the next time the | ||
| application starts. | ||
|
|
||
| **Note:** If the application is quit without calling this API after the |
There was a problem hiding this comment.
I like your new Note: better but this existing one is the same thing 😄
There was a problem hiding this comment.
Should probably remove the old one 👍
There was a problem hiding this comment.
Gah how did I miss that 🙈
zeke
changed the title
|
This is ready to go. |
MarshallOfSound
approved these changes
Jul 24, 2018
MarshallOfSound
deleted the
docs--clarify-default-auto-updater-installation-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has come to light in electron/update-electron-app#22 that it's not strictly necessary to take an action upon a downloaded update, as it will be applied automatically on app restart.