Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: update browser-window-affinity spec to expect #13239

Merged
merged 2 commits into from
Jun 17, 2018
Merged

spec: update browser-window-affinity spec to expect #13239

merged 2 commits into from
Jun 17, 2018

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 13, 2018 •
edited
Loading

Ongoing work to migrate our specs from assert to chai's expect for better error messages.

This PR updates the browser-window-affinity spec.

/cc @alexeykuzmin

@codebytere codebytere requested a review from a team June 13, 2018 17:49
@codebytere codebytere force-pushed the expect-browser-window-affinity branch from 39b340d to 9608772 Compare June 14, 2018 17:22
@alexeykuzmin
Copy link
Contributor

@MarshallOfSound Are we still going to entirely remove that affinity thing?

@codebytere codebytere merged commit 8d5fc61 into master Jun 17, 2018
@zeke zeke deleted the expect-browser-window-affinity branch June 18, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @alexeykuzmin