New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make appUserModelId requirement clearer #13259

Merged
merged 1 commit into from Jun 16, 2018

Conversation

Projects
None yet
4 participants
@felixrieseberg
Member

felixrieseberg commented Jun 15, 2018

I'm not 100% sure if I made a mistake at the beginning of time or if the requirements in Windows 10 have actually changed. The whole notification system has undergone changes, so I think the latter is likely.

Either way, this PR makes the requirements around shortcuts with an appUserModelId and notifications on Windows more clear.

Once #13258 is merged, we can update this further to say that things "just work" in the desktop bridge.

@felixrieseberg felixrieseberg requested a review from electron/docs as a code owner Jun 15, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Jun 15, 2018

Member

if the requirements in Windows 10 have actually changed

Can confirm this wasn't always a requirement (and still isn't in some unexplainable cases), better to document it as required though 😄

Member

MarshallOfSound commented Jun 15, 2018

if the requirements in Windows 10 have actually changed

Can confirm this wasn't always a requirement (and still isn't in some unexplainable cases), better to document it as required though 😄

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Jun 15, 2018

Member

@felixrieseberg is this blocked on that linked PR, or can i merge it?

Member

codebytere commented Jun 15, 2018

@felixrieseberg is this blocked on that linked PR, or can i merge it?

@ckerr ckerr merged commit 1647c12 into master Jun 16, 2018

11 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ckerr ckerr deleted the update-notification-docs branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment