docs: Make appUserModelId requirement clearer #13259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can confirm this wasn't always a requirement (and still isn't in some unexplainable cases), better to document it as required though 😄 |
MarshallOfSound
approved these changes
Jun 15, 2018
codebytere
approved these changes
Jun 15, 2018
|
@felixrieseberg is this blocked on that linked PR, or can i merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if I made a mistake at the beginning of time or if the requirements in Windows 10 have actually changed. The whole notification system has undergone changes, so I think the latter is likely.
Either way, this PR makes the requirements around shortcuts with an
appUserModelIdand notifications on Windows more clear.Once #13258 is merged, we can update this further to say that things "just work" in the desktop bridge.