feat: On macOS, Closing Notifications Triggers the 'close' Event

[sidneys]

🤷🏽‍♂️ Previous Behaviour

On macOS, notifications created via ´Electron.Notification´ module do not emit the close event when closing them via the "Close"-button.

🤷🏽‍♂️ Screenshot

🎯 New Behaviour

When clicking the "Close" button, Notifications created via ´Electron.Notification´ now emit the expected close event. This is supported by both Alert- and ´Banner´-style notifications, and also works when dismissing multiple notifications at the same time.

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[MarshallOfSound]

Using these APIs will prevent MAS apps being added to the store (using private apis is against MAS rules).

Can you wrap the notification center delegate code with if not defined checks for MAS please.

[sidneys]

@MarshallOfSound

I wrapped both calls inside #if !defined(MAS_BUILD) calls.

Cheers,
S

[sidneys]

Dear @MarshallOfSound
Dear @electron/notifications

are the changes i added enough to satisfy the MAS requirements?

Kind regards
S

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[sidneys]

That's awesome. Cheers.