Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use mojo v8 proxy resolver with a utility process #13625

Merged
merged 5 commits into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@deepak1556
Copy link
Member

deepak1556 commented Jul 11, 2018

This moves the proxy resolver to a utility process, which aligns with upstream. Future versions will start using the mojo services. Before this patch, we always intended for the proxy resolver and the node environment in the main process to use separate v8 environments but since 61 they started sharing v8::Platform which caused the crash in #12676 , this should fix it.

Depends on electron/libchromiumcontent#595

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • commit messages or PR title follow semantic commit guidelines
@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Jul 11, 2018

@zcbenz Could you please take a look?

@deepak1556 deepak1556 force-pushed the proxy_resolver_oop branch 2 times, most recently from 860ab53 to 2dc604d Jul 12, 2018

@deepak1556 deepak1556 requested a review from zcbenz Jul 12, 2018

@zcbenz zcbenz force-pushed the proxy_resolver_oop branch from 2dc604d to 65bbf21 Jul 12, 2018

@jkleinsc jkleinsc changed the title build: use mojo v8 proxy resolver with a utility process fix: use mojo v8 proxy resolver with a utility process Jul 12, 2018

@zcbenz

zcbenz approved these changes Jul 12, 2018

@zcbenz zcbenz merged commit 17297d8 into 2-0-x Jul 12, 2018

14 checks passed

Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@zcbenz zcbenz deleted the proxy_resolver_oop branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.