fix: use mojo v8 proxy resolver with a utility process #13625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the proxy resolver to a utility process, which aligns with upstream. Future versions will start using the mojo services. Before this patch, we always intended for the proxy resolver and the node environment in the main process to use separate v8 environments but since 61 they started sharing v8::Platform which caused the crash in #12676 , this should fix it.
Depends on electron/libchromiumcontent#595
Checklist
npm test
passes