-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: speechSynthesis now returns voices on Windows #14070
Conversation
The implementation was brought up-to-speed with Chromium 70.0.3522.1 (https://chromium.googlesource.com/chromium/src.git/+/70.0.3522.1/chrome/browser/speech/tts_win.cc). This to solve issues with Windows not returning voices (electron#11585).
refs: https://cs.chromium.org/chromium/src/chrome/browser/speech/tts_win.cc?q=tts_win&dr Can you add a test for this, to verify that windows OS level voices are returned on Windows 👍 |
@MarshallOfSound That might be a problem since the OS level voices depend on the Windows installation, I had no voices available before I installed the Microsoft Speech Platform and some voices on my PC at home. If you have any idea how a test for this might work I would be glad to implement it. |
@robinwassen Fair enough, if it's not something we can test predictably out of the box let's not waste time figuring it out 👍 |
Release Notes Persisted
|
Ok, so as far as I can tell this issue is fixed and merged to the master. Thanks a lot for that! |
@AlbrechtStriffler there will be a beta release from master by this Friday, you can expect this fix in that release. Thanks! |
I'd like to reopen this issue because it doesn't work for me, though I followed the instructions mentioned above. If I download Chromium Version 74.0.3696.0 (Developer Build) (64-bit) the voices installed on my OS are present when invoking At least I would like to upgrade the version of Chromium used by Electron so I could know where the problem comes from and maybe fix the no-voices issue. How can I do that ? |
Commenting my own comment above. It seems that it works now, I removed the dev dependencies in my local project and use global electron. I think this was the problem. |
The implementation of tts_win.cc was brought up-to-speed with Chromium 70.0.3522.1 (https://chromium.googlesource.com/chromium/src.git/+/70.0.3522.1/chrome/browser/speech/tts_win.cc).
This to solve the issue with no voices being returned on Windows (#11585).
Ping @AlbrechtStriffler
Checklist
npm test
passesSteps to test this
Setup text-to-speech in Windows
Run the demo application
Notes: speech synthesis APIs now return OS voices on Windows