build: move libcc patches to electron repo #14104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to touch lots of libcc files in electron/libchromiumcontent#647 =/ |
nornagon
force-pushed
the
merge-libcc
branch
2 times, most recently
from
e18c102
to
b460bf2
Compare
|
Rebased on top of M67 merge. |
alexeykuzmin
suggested changes
Sep 12, 2018
There was a problem hiding this comment.
👍
Can you please move script/README.md and script/get-patch too?
Also it looks like at least some copied scripts are outdated (e.g. script/lib/git.py). Probably they have been updated in the libcc repo after this PR was initially created.
Can you please copy them again?
nornagon
force-pushed
the
merge-libcc
branch
3 times, most recently
from
ba6d351
to
1902554
Compare
In the GN build, libchromiumcontent is no longer a distinct library, but merely a container for a set of scripts and patches. Maintaining those patches in a separate repository is tedious and error-prone, so merge them into the main repo. Once this is merged and GN is the default way to build Electron, the libchromiumcontent repository can be archived.
nornagon
force-pushed
the
merge-libcc
branch
from
e83c3af
to
5cfdb95
Compare
alexeykuzmin
approved these changes
Sep 13, 2018
nornagon
changed the title
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GN build, libchromiumcontent is no longer a distinct library, but
merely a container for a set of scripts and patches. Maintaining those
patches in a separate repository is tedious and error-prone, so merge
them into the main repo.
Once this is merged and GN is the default way to build Electron, the
libchromiumcontent repository can be archived.
Depends on #14097.
Notes: no-notes