Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add shell = True to make clang-format work on Windows #14121

Merged
merged 1 commit into from
Sep 6, 2018
Merged

fix: add shell = True to make clang-format work on Windows #14121

merged 1 commit into from
Sep 6, 2018

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Aug 15, 2018 •
edited
Loading

Previously clang-format couldn't run on Windows (at least with hyper using PowerShell) since the subprocess.Popen command couldn't find the executable. This fixes that.

Notes: fixes clang-format on Windows

@brenca brenca requested review from codebytere and a team August 15, 2018 22:02
@MarshallOfSound MarshallOfSound merged commit 8e963f1 into master Sep 6, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 6, 2018

Release Notes Persisted

fixes clang-format on Windows

@MarshallOfSound MarshallOfSound deleted the brenca/fix-clang-format branch September 6, 2018 23:49
@alexeykuzmin alexeykuzmin mentioned this pull request Sep 19, 2018
Merged
3 tasks
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenca @MarshallOfSound