refactor: implement crashReporter.start() without the remote module #14434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alexeykuzmin
suggested changes
Sep 3, 2018
electron.gyp
Outdated
| '-r', | ||
| './lib/sandboxed_renderer/api/exports/path.js:path', | ||
| '-r', | ||
| './lib/sandboxed_renderer/api/exports/child_process.js:child_process' |
There was a problem hiding this comment.
Should the GN build config be updated?
miniak
force-pushed
the
miniak/crash-reporter
branch
from
ff6675c
to
f87ac07
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/crash-reporter
branch
4 times, most recently
from
478d532
to
a10e297
Compare
miniak
changed the title
|
@alexeykuzmin it's ready for review. |
miniak
force-pushed
the
miniak/crash-reporter
branch
from
a10e297
to
693ad6a
Compare
miniak
force-pushed
the
miniak/crash-reporter
branch
from
693ad6a
to
963c968
Compare
miniak
force-pushed
the
miniak/crash-reporter
branch
from
963c968
to
5cf3045
Compare
miniak
force-pushed
the
miniak/crash-reporter
branch
from
5cf3045
to
da720ce
Compare
alexeykuzmin
approved these changes
Sep 21, 2018
miniak
requested review from
MarshallOfSound,
codebytere,
ckerr,
tarruda,
nornagon and
deepak1556
miniak
force-pushed
the
miniak/crash-reporter
branch
from
da720ce
to
03bfdce
Compare
codebytere
approved these changes
Sep 24, 2018
MarshallOfSound
approved these changes
Sep 26, 2018
|
No Release Notes |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The
crashReporter.start()method depends on theremotemodule when used in the renderer process. There is a PR, which adds the ability to disable the remote module to increase security, especially in the sandbox #13028. To enable this work, we need to implement this method by sending specialized IPC messages instead of using the remote module, which allows more fine gained validation of the IPCs to make sure they cannot be exploited.Checklist
npm testpassesRelease Notes
Notes: no-notes