Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upci: migrate libcc's Dockerfile to electron and update it #14786
+695
−38
Conversation
nornagon
requested a review
from
jkleinsc
Sep 24, 2018
nornagon
requested a review
from
as a
code owner
Sep 24, 2018
nornagon
reviewed
Sep 24, 2018
Dockerfile.base
Outdated
| && /setup/install-build-deps.sh --syms --no-prompt --no-chromeos-fonts --no-nacl \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN pip install -U crcmod |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nornagon
force-pushed the
new-base-dockerfile
branch
from
dd8bbd8
to
d7c170f
Sep 24, 2018
jkleinsc
added some commits
Sep 24, 2018
nornagon
and others
added some commits
Sep 24, 2018
This comment has been minimized.
This comment has been minimized.
|
Merging with electron-osx-testing not passing because this change just affects Linux builds. |
jkleinsc
merged commit 18c2574
into
master
Sep 25, 2018
28 checks passed
Semantic Pull Request
ready to be squashed
Details
WIP
ready for review
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
ci/circleci: linux-arm-checkout
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-ffmpeg
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-checkout
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-ffmpeg
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-ffmpeg
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-verify-ffmpeg
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-ffmpeg
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-verify-ffmpeg
Your tests passed on CircleCI!
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Sep 25, 2018
|
No Release Notes |
jkleinsc
deleted the
new-base-dockerfile
branch
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nornagon commentedSep 24, 2018
Description of Change
This commit contains a copy of
install-build-deps.shfrom current chromium master because it has a nice--backwards-compatibleoption we can use to hopefully ease pain of being a little behind.This replaces the Dockerfile that used to be present in libcc and is referred to as
electronbuilds/libchromiumcontentin some other Dockerfiles' base images.Checklist
Release Notes
Notes: no-notes