New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate libcc's Dockerfile to electron and update it #14786

Merged
merged 5 commits into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Contributor

nornagon commented Sep 24, 2018

Description of Change

This commit contains a copy of install-build-deps.sh from current chromium master because it has a nice --backwards-compatible option we can use to hopefully ease pain of being a little behind.

This replaces the Dockerfile that used to be present in libcc and is referred to as electronbuilds/libchromiumcontent in some other Dockerfiles' base images.

Checklist
  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@nornagon nornagon requested a review from jkleinsc Sep 24, 2018

@nornagon nornagon requested a review from electron/reviewers as a code owner Sep 24, 2018

&& /setup/install-build-deps.sh --syms --no-prompt --no-chromeos-fonts --no-nacl \
&& rm -rf /var/lib/apt/lists/*
RUN pip install -U crcmod

This comment has been minimized.

@nornagon

nornagon Sep 24, 2018

Contributor

afaict we don't actually use this?

This comment has been minimized.

@nornagon

nornagon Sep 24, 2018

Contributor

oh, it's got some dependency in gsutil somewhere.

@jkleinsc

LGTM

nornagon and others added some commits Sep 24, 2018

Add needed dependencies
nacl contains dependencies needed for arm and ia32 builds
@jkleinsc

This comment has been minimized.

Contributor

jkleinsc commented Sep 25, 2018

Merging with electron-osx-testing not passing because this change just affects Linux builds.

@jkleinsc jkleinsc merged commit 18c2574 into master Sep 25, 2018

28 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-verify-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-verify-ffmpeg Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Sep 25, 2018

No Release Notes

@jkleinsc jkleinsc deleted the new-base-dockerfile branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment