ci: migrate libcc's Dockerfile to electron and update it #14786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
commented
Sep 24, 2018
Dockerfile.base
Outdated
| && /setup/install-build-deps.sh --syms --no-prompt --no-chromeos-fonts --no-nacl \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN pip install -U crcmod |
There was a problem hiding this comment.
afaict we don't actually use this?
There was a problem hiding this comment.
oh, it's got some dependency in gsutil somewhere.
nornagon
force-pushed
the
new-base-dockerfile
branch
from
dd8bbd8
to
d7c170f
Compare
nacl contains dependencies needed for arm and ia32 builds
|
Merging with electron-osx-testing not passing because this change just affects Linux builds. |
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This commit contains a copy of
install-build-deps.shfrom current chromium master because it has a nice--backwards-compatibleoption we can use to hopefully ease pain of being a little behind.This replaces the Dockerfile that used to be present in libcc and is referred to as
electronbuilds/libchromiumcontentin some other Dockerfiles' base images.Checklist
Release Notes
Notes: no-notes