Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support ASAR in fs.copyFile (backport: 3-0-x) #14953

Merged
merged 1 commit into from
Oct 3, 2018
Merged

fix: support ASAR in fs.copyFile (backport: 3-0-x) #14953

merged 1 commit into from
Oct 3, 2018

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 3, 2018

Backport of #14942

See that PR for details.

Close #14320

Notes: Fix fs.copyFile not working with ASAR archives.

@trop trop bot requested a review from a team October 3, 2018 16:36
@trop trop bot mentioned this pull request Oct 3, 2018
Merged
4 tasks
@trop trop bot added the backport This is a backport PR label Oct 3, 2018
@MarshallOfSound MarshallOfSound merged commit 73935bc into electron:3-0-x Oct 3, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 3, 2018

Release Notes Persisted

Fix fs.copyFile not working with ASAR archives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @MarshallOfSound @zcbenz