Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Introduce LocationProxy for BrowserWindowProxy #15019

Merged
merged 3 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@Anrock
Copy link
Contributor

commented Oct 8, 2018

Fixes #15017

Description of Change

Implements proxy Location object for BrowserWindowProxy

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: Implement proper Location object for BrowserWindowProxy

@Anrock Anrock requested a review from as a code owner Oct 8, 2018

@codebytere

This comment has been minimized.

Copy link
Member

commented Oct 8, 2018

@Anrock did you test this locally? i'm seeing 10 test failures for most builds that all look related

@Anrock

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2018

@codebytere no, i didn't - once again git pull rendered master unbuildable for me. Therefore marked as WIP.

However i'm interested in top-level review if this approach is viable and if it's a welcomed change in regards of electron architecture..

@Anrock Anrock changed the title WIP: Introduce LocationProxy for BrowserWindowProxy fix: Introduce LocationProxy for BrowserWindowProxy Oct 9, 2018

@Anrock

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2018

Removing WIP: works for me, usual 4-5 test fails as on master.

@Anrock

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2018

Is there relevant unit tests for location object i should change?

@Anrock

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2018

@Anrock

https://circleci.com/gh/electron/electron/82004
Among all failed tests only these two look like real failures:

  • "chromium feature window.open defines a window.location getter"
  • "BrowserWindow module contextIsolation option with and without sandbox option doesn't break ipc serialization"

Can you please fix them?

@Anrock

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2018

@alexeykuzmin i'll take a look at it as soon as i can. Don't have much free time for it, unfortunately.

@zcbenz

zcbenz approved these changes Dec 4, 2018

Copy link
Member

left a comment

This looks good to me, I have fixed the failing tests by adding a setter for window.location.

@zcbenz zcbenz merged commit 5bc86ea into electron:master Dec 4, 2018

21 of 22 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
electron-lint Build #20181204.8 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 4, 2018

Release Notes Persisted

Implement proper Location object for BrowserWindowProxy

@Anrock Anrock deleted the Anrock:child-window-location branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.