Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove desktop_screen_win.patch #15232

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

nornagon
Copy link
Member

Description of Change

The patched function is never called with a null argument (all call-sites are guarded)

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

that function is never called with a null argument (all call-sites are guarded)
@nornagon nornagon requested a review from a team October 17, 2018 21:47
@nornagon
Copy link
Member Author

Merging with pending mac builds because this only touches windows.

@nornagon nornagon merged commit ac6d815 into master Oct 17, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 17, 2018

No Release Notes

@codebytere codebytere deleted the remove-desktop-screen-win-patch branch October 23, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants