Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow registering multiple shortcuts #15542

Merged
merged 7 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Nov 2, 2018

Description of Change

This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.

Ex.

const ret = globalShortcut.registerAll(['CmdOrCtrl+X', 'CmdOrCtrl+Y'], () => {
   console.log('did something!')
})

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: allow registering of multiple globalShortcuts

@codebytere codebytere requested review from as code owners Nov 2, 2018

Show resolved Hide resolved docs/api/global-shortcut.md Outdated
@brenca

brenca approved these changes Nov 5, 2018

Copy link
Member

left a comment

lgtm 👍

codebytere added some commits Nov 6, 2018

@codebytere codebytere merged commit e9ba26f into master Nov 7, 2018

25 of 27 checks passed

electron-osx-testing Build #20181106.8 has test failures
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181106.8 succeeded
Details
electron-arm64-testing Build #20181106.8 succeeded
Details
electron-lint Build #20181106.7 succeeded
Details
electron-mas-testing Build #20181106.8 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 7, 2018

Release Notes Persisted

allow registering of multiple globalShortcuts

@codebytere codebytere deleted the multiple-globals branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.