New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the "second-instance" event handler signature in the docs (backport: 4-0-x) #15548

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Nov 2, 2018

Backport of #15546

See that PR for details.

Notes: docs: fix the "second-instance" event handler signature in the docs

@trop trop bot requested a review from electron/docs as a code owner Nov 2, 2018

@trop trop bot referenced this pull request Nov 2, 2018

Merged

docs: fix the "second-instance" event handler signature in the docs #15546

3 of 3 tasks complete

@trop trop bot added 4-0-x backport labels Nov 2, 2018

@MarshallOfSound MarshallOfSound merged commit 8e31642 into electron:4-0-x Nov 2, 2018

20 of 21 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 2, 2018

Release Notes Persisted

docs: fix the "second-instance" event handler signature in the docs

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Nov 2, 2018

/trop run backport-to master

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 2, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "master" here we go! :D

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 2, 2018

I have automatically backported this PR to "master", please check out #15551

@trop trop bot added the merged/master label Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment