New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Renable ffmpeg and mksnapshot tests on Azure Devops #15800

Merged
merged 4 commits into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@jkleinsc
Contributor

jkleinsc commented Nov 21, 2018

This PR addresses the issue that was causing verify-ffmpeg and verify-mksnapshot to timeout on Azure Devops. Those tests were disabled via #15732. The issue was that on the CI machines there were previously crashed Electron instances that were causing this dialog to appear:
crashed_electron. In order to resolve this issue, verify-ffmpeg and verify-mksnapshot now run with the Electron spec tests on a different dynamic VM.

This PR also adds testing of ffmpeg and native_mksnapshot on arm/arm64

Description of Change

Checklist

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Nov 21, 2018

@ckerr

ckerr approved these changes Nov 21, 2018

ci: Renable ffmpeg and mksnapshot tests on VSTS
Also, add testing of ffmpeg and mksnapshot to arm tests

@jkleinsc jkleinsc force-pushed the update-ffmpeg-mksnapshot-tests branch from d788445 to fdd2437 Nov 21, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Nov 28, 2018

Still seems to be failing on verify, should this be marked a WIP?

@jkleinsc jkleinsc removed the target/4-0-x label Nov 30, 2018

@jkleinsc jkleinsc merged commit 515525c into master Nov 30, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 30, 2018

No Release Notes

@jkleinsc jkleinsc deleted the update-ffmpeg-mksnapshot-tests branch Nov 30, 2018

@jkleinsc jkleinsc referenced this pull request Nov 30, 2018

Merged

ci: fix/add ffmpeg and mksnapshot tests on Azure Devops #15902

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment