ci: Renable ffmpeg and mksnapshot tests on Azure Devops #15800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Nov 21, 2018
Also, add testing of ffmpeg and mksnapshot to arm tests
jkleinsc
force-pushed
the
update-ffmpeg-mksnapshot-tests
branch
from
d788445
to
fdd2437
Compare
codebytere
approved these changes
Nov 23, 2018
|
Still seems to be failing on verify, should this be marked a WIP? |
|
No Release Notes |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that was causing verify-ffmpeg and verify-mksnapshot to timeout on Azure Devops. Those tests were disabled via #15732. The issue was that on the CI machines there were previously crashed Electron instances that were causing this dialog to appear:
. In order to resolve this issue, verify-ffmpeg and verify-mksnapshot now run with the Electron spec tests on a different dynamic VM.
This PR also adds testing of ffmpeg and native_mksnapshot on arm/arm64
Description of Change
Checklist
npm testpassesRelease Notes
Notes: no-notes