Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mac support to systemPrefs.getAccentColor() #16251

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Jan 3, 2019

Description of Change

Add MacOS support for systemPreferences.getAccentColor().

/cc @miniak

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Added macOS support for systemPreferences.getAccentColor().

@codebytere codebytere requested review from as code owners Jan 3, 2019

@codebytere codebytere force-pushed the add-accent-support-mac branch from fc025ae to 5efc064 Jan 3, 2019

@miniak

miniak approved these changes Jan 3, 2019

@codebytere codebytere force-pushed the add-accent-support-mac branch from aa45499 to 2eab311 Jan 3, 2019

@BinaryMuse
Copy link
Member

left a comment

👹 📝 The red docs ogre approves

@codebytere codebytere merged commit 439ba51 into master Jan 3, 2019

23 of 27 checks passed

electron-arm-testing Build #20190103.30 has failed
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm64-testing Build #20190103.30 succeeded
Details
electron-lint Build #20190103.40 succeeded
Details
electron-mas-testing Build #20190103.49 succeeded
Details
electron-osx-testing Build #20190103.49 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 3, 2019

Release Notes Persisted

Added macOS support for systemPreferences.getAccentColor().

@codebytere codebytere deleted the add-accent-support-mac branch Jan 3, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

feat: add mac support to systemPrefs.getAccentColor() (electron#16251)
* feat: add mac support to systemPrefs.getAccentColor()

* note 10.14 retriction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.