New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fileMenu / viewMenu / appMenu roles #16328

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

miniak commented Jan 8, 2019

Description of Change

This allows the default menu code to be simplified significantly.

Checklist

Release Notes

Notes: Added fileMenu / viewMenu / appMenu roles

@miniak miniak requested review from electron/docs as code owners Jan 8, 2019

@miniak miniak referenced this pull request Jan 8, 2019

Merged

feat: use default-app behavior in packaged apps #16310

6 of 6 tasks complete

@miniak miniak changed the title feat: add `fileMenu` / `viewMenu` / `appMenu` roles feat: add fileMenu / viewMenu / appMenu roles Jan 8, 2019

@miniak miniak force-pushed the miniak/menu-roles branch from e0c97bb to 9c7dc8c Jan 8, 2019

@miniak miniak requested review from nornagon , MarshallOfSound and codebytere Jan 8, 2019

@miniak miniak self-assigned this Jan 8, 2019

@miniak miniak force-pushed the miniak/menu-roles branch 2 times, most recently from ecebb9b to 433542c Jan 8, 2019

@miniak miniak force-pushed the miniak/menu-roles branch from 433542c to 59be8f5 Jan 9, 2019

]
},
// { role: 'viewMenu' }

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Jan 9, 2019

Contributor

Is it needed here? If is a comment, I don't really understand what it means =/

This comment has been minimized.

@miniak

miniak Jan 9, 2019

Contributor

It was mean to suggest that it’s equivalent of using those menu roles

@codebytere
Copy link
Member

codebytere left a comment

looks fine to me on the whole!

@alexeykuzmin alexeykuzmin merged commit eb02a42 into master Jan 10, 2019

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 10, 2019

Release Notes Persisted

Added fileMenu / viewMenu / appMenu roles

@alexeykuzmin alexeykuzmin deleted the miniak/menu-roles branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment