Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ELECTRON_DISABLE_SANDBOX env var #16576

Merged
merged 1 commit into from
Jan 29, 2019
Merged

feat: add ELECTRON_DISABLE_SANDBOX env var #16576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions atom/app/atom_main_delegate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ bool AtomMainDelegate::BasicStartupComplete(int* exit_code) {
if (env->HasVar("ELECTRON_ENABLE_STACK_DUMPING"))
base::debug::EnableInProcessStackDumping();

if (env->HasVar("ELECTRON_DISABLE_SANDBOX"))
command_line->AppendSwitch(service_manager::switches::kNoSandbox);

chrome::RegisterPathProvider();

#if defined(OS_MACOSX)
Expand Down
6 changes: 6 additions & 0 deletions vsts-arm-test-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,24 @@ steps:
python electron/script/verify-ffmpeg.py --source-root "$PWD" --build-dir out/Default --ffmpeg-path out/ffmpeg
displayName: Verify non proprietary ffmpeg
timeoutInMinutes: 5
env:
ELECTRON_DISABLE_SANDBOX: 1

- bash: |
cd src
python electron/script/verify-mksnapshot.py --source-root "$PWD" --build-dir out/Default
displayName: Verify mksnapshot
timeoutInMinutes: 5
env:
ELECTRON_DISABLE_SANDBOX: 1

- bash: |
cd src
./out/Default/electron electron/spec --ci --enable-logging
displayName: 'Run Electron tests'
timeoutInMinutes: 10
env:
ELECTRON_DISABLE_SANDBOX: 1

- task: PublishTestResults@2
displayName: 'Publish Test Results'
Expand Down