Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle IPC for promise-based methods #16654

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Jan 31, 2019

Description of Change

Backport of #16433.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere requested a review from as a code owner Jan 31, 2019

@codebytere codebytere changed the title fix: correctly handle IPC for promise-based methods (#16433) fix: correctly handle IPC for promise-based methods Jan 31, 2019

@codebytere codebytere merged commit 0b7680a into 4-0-x Feb 5, 2019

19 of 20 checks passed

ci/circleci: linux-x64-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 5, 2019

Release Notes Persisted

Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere deleted the ipc-passing-async-4 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.