Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify session proxy methods #17222

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 4, 2019

Description of Change

Promisify session.setProxy() and session.resolveProxy().

cc @deepak1556 @zcbenz @miniak

Checklist

Release Notes

Notes: Converted session.setProxy() and session.resolveProxy() to return Promises instead of taking callbacks.

@deepak1556
Copy link
Member

left a comment

LGTM, with some code style changes.

atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
@deepak1556 deepak1556 referenced this pull request Mar 4, 2019
5 of 5 tasks complete

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 5, 2019

spec/api-session-spec.js Show resolved Hide resolved
spec/api-session-spec.js Show resolved Hide resolved
spec/api-session-spec.js Show resolved Hide resolved
spec/api-session-spec.js Outdated Show resolved Hide resolved

@codebytere codebytere force-pushed the promise-session-proxy branch 2 times, most recently from 76e6c6d to 1cacc87 Mar 8, 2019

spec/api-session-spec.js Outdated Show resolved Hide resolved
spec/package-lock.json Outdated Show resolved Hide resolved

@codebytere codebytere force-pushed the promise-session-proxy branch 2 times, most recently from a8c1397 to 48ecf61 Mar 8, 2019

@miniak

miniak approved these changes Mar 8, 2019

@codebytere codebytere force-pushed the promise-session-proxy branch from 48ecf61 to 16020a0 Mar 8, 2019

@codebytere codebytere force-pushed the promise-session-proxy branch from 16020a0 to 9212388 Mar 8, 2019

@codebytere codebytere merged commit 2769e75 into master Mar 8, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190308.44 succeeded
Details
electron-arm64-testing Build #20190308.46 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 8, 2019

Release Notes Persisted

Converted session.setProxy() and session.resolveProxy() to return Promises instead of taking callbacks.

@codebytere codebytere deleted the promise-session-proxy branch Mar 8, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.