Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify session proxy methods #17222

Merged
merged 1 commit into from
Mar 8, 2019
Merged

feat: promisify session proxy methods #17222

merged 1 commit into from
Mar 8, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 4, 2019 •
edited
Loading

Description of Change

Promisify session.setProxy() and session.resolveProxy().

cc @deepak1556 @zcbenz @miniak

Checklist

Release Notes

Notes: Converted session.setProxy() and session.resolveProxy() to return Promises instead of taking callbacks.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 4, 2019
@codebytere codebytere added the semver/major incompatible API changes label Mar 4, 2019
deepak1556
deepak1556 reviewed Mar 4, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some code style changes.

atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
@deepak1556 deepak1556 mentioned this pull request Mar 4, 2019
Merged
5 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 5, 2019
miniak
miniak requested changes Mar 7, 2019
View reviewed changes
spec/api-session-spec.js Show resolved Hide resolved
spec/api-session-spec.js Show resolved Hide resolved
spec/api-session-spec.js Show resolved Hide resolved
spec/api-session-spec.js Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the promise-session-proxy branch 2 times, most recently from 76e6c6d to 1cacc87 Compare March 8, 2019 04:33
miniak
miniak requested changes Mar 8, 2019
View reviewed changes
spec/api-session-spec.js Outdated Show resolved Hide resolved
spec/package-lock.json Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the promise-session-proxy branch 2 times, most recently from a8c1397 to 48ecf61 Compare March 8, 2019 16:37
@codebytere codebytere merged commit 2769e75 into master Mar 8, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2019

Release Notes Persisted

Converted session.setProxy() and session.resolveProxy() to return Promises instead of taking callbacks.

@codebytere codebytere deleted the promise-session-proxy branch March 8, 2019 20:51
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: promisify session proxy methods (electron#17222)
2b10be3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 left review comments

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @deepak1556 @miniak @MarshallOfSound