Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify session.clearAuthCache() #17259

Merged
merged 2 commits into from Mar 9, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 7, 2019

Description of Change

Promisifies session.clearAuthCache().

Checklist

Release Notes

Notes: Converted session.clearAuthCache() to return a promise instead of optionally taking a callback.

@codebytere codebytere force-pushed the promisify-clearauthcache branch 5 times, most recently from 203b76b to 3ca656b Mar 7, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 8, 2019

@deepak1556
Copy link
Member

left a comment

LGTM, with style change.

Show resolved Hide resolved atom/browser/api/atom_api_session.cc

@codebytere codebytere force-pushed the promisify-clearauthcache branch from 3ca656b to dffb858 Mar 8, 2019

@miniak

miniak approved these changes Mar 8, 2019

@codebytere codebytere force-pushed the promisify-clearauthcache branch from dffb858 to 9789d15 Mar 8, 2019

@codebytere codebytere merged commit 9ea6c01 into master Mar 9, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190308.68 succeeded
Details
electron-arm64-testing Build #20190308.70 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 9, 2019

Release Notes Persisted

Converted session.clearAuthCache() to return a promise instead of optionally taking a callback.

@codebytere codebytere deleted the promisify-clearauthcache branch Mar 9, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

feat: promisify session.clearAuthCache() (electron#17259)
* feat: promisify session.clearAuthCache()

* remove unused callback runner helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.