Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the correct HostPort into the node inspector #17380

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Mar 14, 2019

Fixes #17348

Description of Change

We were passing the incorrect HostPort instance into the inspector start call. This passes the correct one in.

Release Notes

Notes: launching the node inspector through --inspect now listens on the correct port when one is provided

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 15, 2019

@MarshallOfSound MarshallOfSound merged commit 5025c99 into master Mar 18, 2019

14 checks passed

Artifact Comparison No Changes
Details
Backportable? - 5-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190314.3 succeeded
Details
electron-arm64-testing Build #20190314.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 18, 2019

Release Notes Persisted

launching the node inspector through --inspect now listens on the correct port when one is provided

@trop

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

I have automatically backported this PR to "5-0-x", please check out #17439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.