New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update sandbox-option.md #17468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/docs-sandbox
branch
from
March 20, 2019 04:51
dc932dd
to
816ecbc
Compare
miniak
changed the title
docs: mixed mode sandbox is enabled by default + update list of modules available in sandbox
docs: update sandbox-option.md
Mar 20, 2019
ppontes
requested changes
Mar 20, 2019
miniak
force-pushed
the
miniak/docs-sandbox
branch
from
March 20, 2019 18:45
816ecbc
to
40ec62e
Compare
miniak
force-pushed
the
miniak/docs-sandbox
branch
from
March 20, 2019 18:47
40ec62e
to
d52fb84
Compare
ppontes
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nornagon
approved these changes
Mar 20, 2019
Co-Authored-By: miniak <milan.burda@gmail.com>
alexeykuzmin
approved these changes
Mar 21, 2019
No Release Notes |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
* docs: update sandbox-option.md * Update docs/api/sandbox-option.md Co-Authored-By: miniak <milan.burda@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
--enable-sandbox
command-line argument withapp.enableSandbox
Follow up to:
Checklist
npm test
passesRelease Notes
Notes: no-notes
/cc @electron/wg-security