Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport [IntersectionObserver] Report coordinates as CSS pixels #17583

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

miniak commented Mar 27, 2019

Description of Change

Backport https://chromium-review.googlesource.com/c/chromium/src/+/1250121/

[IntersectionObserver] Report coordinates as CSS pixels.
Prior to this patch, IntersectionObserverEntry was reporting coordinates in device pixels.

Checklist

Release Notes

Notes: Fixed IntersectionObserver.rootBounds for navigator zoom != 100%

@miniak miniak self-assigned this Mar 27, 2019

@miniak miniak marked this pull request as ready for review Mar 27, 2019

@miniak miniak requested a review from MarshallOfSound Mar 27, 2019

@deepak1556 deepak1556 requested a review from electron/wg-upgrades Mar 28, 2019

@miniak miniak force-pushed the miniak/intersection-observer-4-1-x branch from f8125c3 to fabe20c Mar 28, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 28, 2019

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Mar 29, 2019

Commit c02251d2... initially landed in 71.0.3565.0

It's ok to backport to the 4-1-x only 👍

@alexeykuzmin alexeykuzmin merged commit 3001c76 into 4-1-x Mar 29, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 29, 2019

Release Notes Persisted

Fixed IntersectionObserver.rootBounds for navigator zoom != 100%

@alexeykuzmin alexeykuzmin deleted the miniak/intersection-observer-4-1-x branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.