New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fs.promises does not work with ASAR paths #18092
Conversation
46b0047
to
7d21b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but second opinion from @MarshallOfSound?
ideally we'd wrap the actual methods instead of util.promisifying
them but that'd add a lot of code overhead so i feel comfortable with this approach as it stands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that Object.keys(require('fs')) === Object.keys(require('original-fs'))
and Object.keys(require('fs').promises) === Object.keys(require('original-fs').promises)
just to ensure we aren't adding / removing APIs
4d2e23c
to
d112ffd
Compare
@MarshallOfSound test added |
d112ffd
to
d9b774a
Compare
@zcbenz can you have a look, please? |
Release Notes Persisted
|
I have automatically backported this PR to "5-0-x", please check out #18115 |
I have automatically backported this PR to "6-0-x", please check out #18114 |
@miniak this should probably also go to |
Description of Change
Closes #17190.
Added missing overrides for
fs.promises
APIs implementing ASAR support. Related to #17999.Checklist
npm test
passesRelease Notes
Notes: Fixed
fs.promises
APIs not working with ASAR paths.