Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove deprecated octokit auth calls #18205

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented May 8, 2019

Description of Change

octokit.authenticate is deprecated and its notices caused release failures. This fixes that.

cc @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere merged commit 6770a8c into master May 8, 2019

10 of 14 checks passed

electron-arm64-testing Build #20190508.1 failed
Details
electron-arm-testing
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Backportable? - 6-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found

@codebytere codebytere deleted the fix-auth-octokit branch May 8, 2019

@release-clerk

This comment has been minimized.

Copy link

commented May 8, 2019

No Release Notes

@trop

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

I have automatically backported this PR to "6-0-x", please check out #18206

Kiku-git added a commit to Kiku-git/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.