Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'gpu-info-update' event to app #18250

Merged
merged 1 commit into from May 18, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented May 10, 2019

Description of Change

Added gpu-info-update event to app, which is emitted whenever there is a GPU info update.
Reported by GpuDataManagerObserver::OnGpuInfoUpdate

Checklist

Release Notes

Notes: Added gpu-info-update event to app, which is emitted whenever there is a GPU info update.

@miniak miniak self-assigned this May 10, 2019
@miniak miniak force-pushed the miniak/gpu-info-update branch from 3cbb120 to c868015 May 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label May 11, 2019
docs/api/app.md Show resolved Hide resolved
@miniak miniak force-pushed the miniak/gpu-info-update branch from c868015 to 79cc8ad May 13, 2019
@miniak miniak requested review from deepak1556 and codebytere May 13, 2019
Copy link
Member

deepak1556 left a comment

Is this purpose of the event to ease the use of app.getGPUInfo ?

@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented May 14, 2019

@deepak1556 the problem is that since Electron 3, app.getGPUFeatureStatus() only returns correct values after the GPU process is launched, which cannot be deterministically detected with the current API. This new event accurately indicates that the GPU information has changed.

Copy link
Member

deepak1556 left a comment

Thanks for the explanation 👍

@miniak miniak requested review from MarshallOfSound and zcbenz May 15, 2019
@zcbenz
zcbenz approved these changes May 18, 2019
@zcbenz zcbenz merged commit 2b4ad2c into master May 18, 2019
13 checks passed
13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190513.9 succeeded
Details
electron-arm64-testing Build #20190513.9 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented May 18, 2019

Release Notes Persisted

Added gpu-info-update event to app, which is emitted whenever there is a GPU info update.

@zcbenz zcbenz deleted the miniak/gpu-info-update branch May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.