Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'gpu-info-update' event to app #18250

Merged
merged 1 commit into from
May 18, 2019
Merged

feat: add 'gpu-info-update' event to app #18250

merged 1 commit into from
May 18, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 10, 2019 •
edited
Loading

Description of Change

Added gpu-info-update event to app, which is emitted whenever there is a GPU info update.
Reported by GpuDataManagerObserver::OnGpuInfoUpdate

Checklist

Release Notes

Notes: Added gpu-info-update event to app, which is emitted whenever there is a GPU info update.

@miniak miniak self-assigned this May 10, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 11, 2019
ppontes
ppontes approved these changes May 13, 2019
View reviewed changes
docs/api/app.md Show resolved Hide resolved
deepak1556
deepak1556 reviewed May 13, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this purpose of the event to ease the use of app.getGPUInfo ?

@miniak
Copy link
Contributor Author

miniak commented May 14, 2019 •
edited
Loading

@deepak1556 the problem is that since Electron 3, app.getGPUFeatureStatus() only returns correct values after the GPU process is launched, which cannot be deterministically detected with the current API. This new event accurately indicates that the GPU information has changed.

deepak1556
deepak1556 approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation 👍

@zcbenz zcbenz merged commit 2b4ad2c into master May 18, 2019
@release-clerk
Copy link

release-clerk bot commented May 18, 2019

Release Notes Persisted

Added gpu-info-update event to app, which is emitted whenever there is a GPU info update.

@zcbenz zcbenz deleted the miniak/gpu-info-update branch May 18, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@ppontes ppontes ppontes approved these changes

@codebytere codebytere Awaiting requested review from codebytere

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miniak @alexeykuzmin @zcbenz @deepak1556 @ppontes