Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default enable_negotiate_port to false #18284

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

commented May 13, 2019

Backport of #18251

See that PR for details.

Notes: Fixed a regression in Kerberos SPN generation. In the M69 upgrade, the default for the enable_negotiate_port option was inadvertently changed from false to true; this restores the former behavior and aligns with Chromium.

@trop trop bot referenced this pull request May 13, 2019

Merged

fix: default enable_negotiate_port to false #18251

3 of 6 tasks complete

@trop trop bot added 5-0-x backport labels May 13, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 14, 2019

@nornagon nornagon merged commit a60ad6a into 5-0-x May 15, 2019

11 of 13 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
electron-arm-testing Build #20190513.14 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190513.14 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 15, 2019

Release Notes Persisted

Fixed a regression in Kerberos SPN generation. In the M69 upgrade, the default for the enable_negotiate_port option was inadvertently changed from false to true; this restores the former behavior and aligns with Chromium.

@nornagon nornagon deleted the trop/5-0-x-bp-fix-default-enable_negotiate_port-to-false-1557772094904 branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.