Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default enable_negotiate_port to false #18284

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 13, 2019

Backport of #18251

See that PR for details.

Notes: Fixed a regression in Kerberos SPN generation. In the M69 upgrade, the default for the enable_negotiate_port option was inadvertently changed from false to true; this restores the former behavior and aligns with Chromium.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 13, 2019
@trop trop bot mentioned this pull request May 13, 2019
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels May 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 14, 2019
@nornagon nornagon merged commit a60ad6a into 5-0-x May 15, 2019
@release-clerk
Copy link

release-clerk bot commented May 15, 2019

Release Notes Persisted

Fixed a regression in Kerberos SPN generation. In the M69 upgrade, the default for the enable_negotiate_port option was inadvertently changed from false to true; this restores the former behavior and aligns with Chromium.

@nornagon nornagon deleted the trop/5-0-x-bp-fix-default-enable_negotiate_port-to-false-1557772094904 branch May 15, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant