Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the FileSelectHelper to support the new promise API #18341

Merged
merged 1 commit into from May 21, 2019
Merged

fix: update the FileSelectHelper to support the new promise API #18341

merged 1 commit into from May 21, 2019

Commits on May 17, 2019

  1. fix: update the FileSelectHelper to support the new promise API (#18288) 

    * fix: update the FileSelectHelper to support the new promise API

Fixes #18254

So it turns out we've successfully introduced a way to write
non-typesafe C++.

This fixes two things:
* Uses the object the promise resolves
* Ensures we attach the Then handler before moving the promise

* fix: also fix misuse of Promise::Then in the download manager
    @MarshallOfSound
    MarshallOfSound committed May 17, 2019
    Copy the full SHA
    ce0ecc5 View commit details
    Browse the repository at this point in the history