-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bundle the browser and renderer process electron code #18553
Merged
Commits on May 31, 2019
-
refactor: bundle the browser and renderer process electron code
* Bundles browser/init and renderer/init * Improves load performance of main process by ~40% * Improves load performance of renderer process by ~30% * Prevents users from importing our "requiring" our internal logic such as ipc-main-internal. This makes those message buses safer as they are less accessible, there is still some more work to be done though to lock down those buses completely. * The electron.asar file now only contains 2 files, as a future improvement maybe we can use atom_natives to ship these two files embedded in the binary * This also removes our dependency on browserify which had some strange edge cases that caused us to have to hack around require-order and stopped us using certain ES6/7 features we should have been able to use (async / await in some files in the sandboxed renderer init script) TLDR: Things are faster and better :)
Configuration menu - View commit details
-
Copy full SHA for 50e0574 - Browse repository at this point
Copy the full SHA 50e0574View commit details
Commits on Jun 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2ad1e29 - Browse repository at this point
Copy the full SHA 2ad1e29View commit details -
Configuration menu - View commit details
-
Copy full SHA for c788d29 - Browse repository at this point
Copy the full SHA c788d29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 685683b - Browse repository at this point
Copy the full SHA 685683bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c43f6 - Browse repository at this point
Copy the full SHA f6c43f6View commit details -
fix: use webpacks ProvidePlugin to keep global, process and Buffer al…
…ive after deletion from global scope for use in internal code
Configuration menu - View commit details
-
Copy full SHA for 5b5b146 - Browse repository at this point
Copy the full SHA 5b5b146View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81db591 - Browse repository at this point
Copy the full SHA 81db591View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6643d0a - Browse repository at this point
Copy the full SHA 6643d0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d18b44 - Browse repository at this point
Copy the full SHA 8d18b44View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.