Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bundle the browser and renderer process electron code #18553

Merged
merged 9 commits into from
Jun 2, 2019

Commits on May 31, 2019

  1. refactor: bundle the browser and renderer process electron code

    * Bundles browser/init and renderer/init
      * Improves load performance of main process by ~40%
      * Improves load performance of renderer process by ~30%
    * Prevents users from importing our "requiring" our internal logic such
    as ipc-main-internal.  This makes those message buses safer as they are
    less accessible, there is still some more work to be done though to lock
    down those buses completely.
    * The electron.asar file now only contains 2 files, as a future
    improvement maybe we can use atom_natives to ship these two files
    embedded in the binary
    * This also removes our dependency on browserify which had some strange
    edge cases that caused us to have to hack around require-order and
    stopped us using certain ES6/7 features we should have been able to use
    (async / await in some files in the sandboxed renderer init script)
    
    TLDR: Things are faster and better :)
    MarshallOfSound committed May 31, 2019
    Configuration menu
    Copy the full SHA
    50e0574 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2019

  1. Configuration menu
    Copy the full SHA
    2ad1e29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c788d29 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    685683b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f6c43f6 View commit details
    Browse the repository at this point in the history
  5. fix: use webpacks ProvidePlugin to keep global, process and Buffer al…

    …ive after deletion from global scope for use in internal code
    MarshallOfSound committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    5b5b146 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    81db591 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6643d0a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8d18b44 View commit details
    Browse the repository at this point in the history