Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silent printing mode #19037

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@codebytere
Copy link
Member

commented Jun 28, 2019

Backport of #18979.

See that PR for more details.

Notes: Fixed silent printing across platforms.

@codebytere codebytere requested a review from electron/wg-upgrades as a code owner Jun 28, 2019

@trop trop bot referenced this pull request Jun 28, 2019

Merged

fix: silent printing mode #18979

4 of 4 tasks complete

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 28, 2019

@ckerr

ckerr approved these changes Jul 1, 2019

Copy link
Member

left a comment

👍

@jkleinsc jkleinsc merged commit 48bc247 into 6-0-x Jul 2, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190628.27 succeeded
Details
electron-arm64-testing Build #20190628.27 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 2, 2019

Release Notes Persisted

Fixed silent printing across platforms.

@jkleinsc jkleinsc deleted the print-silent-6 branch Jul 2, 2019

@ryzokuken

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@codebytere do you think we should prefix backports with a descriptive label like Node? This was super confusing in my notifications since I had three PRs with the same title (original and two backports).

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

They should all be labeled, which differentiates them in the UI :)

@sarathjasrin

This comment has been minimized.

Copy link

commented Jul 31, 2019

This is not fixed still Version : 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.