Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport workaround for blockfile cache corruption on macOS #19212

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@nornagon
Copy link
Member

commented Jul 11, 2019

Description of Change

Backport of https://chromium-review.googlesource.com/c/chromium/src/+/1347109

Workaround apparent data corruption in blockfile on OS X 10.14 by switching backends.

Fixes #16383.

Checklist

Release Notes

Notes: Backported a workaround for a cache corruption issue that could affect users on macOS 10.14.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Jul 11, 2019

@jkleinsc jkleinsc merged commit 6a1d3e8 into 4-2-x Jul 11, 2019

11 of 12 checks passed

Valid Backport Invalid Backport
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 11, 2019

Release Notes Persisted

Backported a workaround for a cache corruption issue that could affect users on macOS 10.14.

@jkleinsc jkleinsc deleted the backport/4-2-x/mac-simple-cache branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.