Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clearing of the backgroundColor property on TouchBarButton #19471

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix: clearing of the backgroundColor property on TouchBarButton #19471

merged 1 commit into from
Jul 29, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 26, 2019

Backport of #19437

See that PR for details.

Notes: Fixed setting the backgroundColor property on TouchBarButton to default by assigning null after the item is constructed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2019
@trop trop bot mentioned this pull request Jul 26, 2019
Merged
4 tasks
@trop trop bot added 6-0-x backport This is a backport PR labels Jul 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 26, 2019
@codebytere codebytere merged commit c006a6d into 6-0-x Jul 29, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 29, 2019

Release Notes Persisted

Fixed setting the backgroundColor property on TouchBarButton to default by assigning null after the item is constructed.

@codebytere codebytere deleted the trop/6-0-x-bp-fix-clearing-of-the-backgroundcolor-property-on-touchbarbutton-1564134782149 branch July 29, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @codebytere @miniak