fix: clearRecentDocuments role on Windows #19599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
platform/windows
semver/patch
codebytere
changed the title
zcbenz
requested changes
Aug 5, 2019
zcbenz
approved these changes
Aug 5, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I have automatically backported this PR to "6-0-x", please check out #19637 |
|
I have automatically backported this PR to "7-0-x", please check out #19638 |
codebytere
added a commit
that referenced
this pull request
Aug 6, 2019
* fix: clear recent documents on windows * chore: don't check for version < win 7
|
A maintainer has manually backported this PR to "5-0-x", please check out #19640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #19588.
Per documentation,
SHAddToRecentDocscan also be used to clear all recent documents. This switches our impl to use that fn and passesnullptras the second argument to clear all recent docs:cc @deermichel
Checklist
npm testpassesRelease Notes
Notes: Fixed the
clearRecentDocumentsMenuItem role on Windows.