Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 78.0.3896.6 (7-0-x) #19609

Merged
merged 21 commits into from Aug 30, 2019
Merged

Conversation

electron-bot
Copy link
Contributor

@electron-bot electron-bot commented Aug 3, 2019

Updating Chromium to 78.0.3896.6.

See all changes in 78.0.3866.0..78.0.3896.6

Notes: Updated Chromium to 78.0.3896.6.

@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3873.1 (7-0-x) chore: bump chromium to 78.0.3874.1 (7-0-x) Aug 4, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3874.1 (7-0-x) chore: bump chromium to 78.0.3874.3 (7-0-x) Aug 5, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3874.3 (7-0-x) chore: bump chromium to 78.0.3875.1 (7-0-x) Aug 6, 2019
@electron-bot electron-bot requested a review from a team as a code owner August 6, 2019 18:44
@MarshallOfSound
Copy link
Member

In theory folks the changes for the master roll should just be copied over to this branch. The chromium ref is basically identical

@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3875.1 (7-0-x) chore: bump chromium to 78.0.3876.1 (7-0-x) Aug 7, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3876.1 (7-0-x) chore: bump chromium to 78.0.3877.1 (7-0-x) Aug 8, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3877.1 (7-0-x) chore: bump chromium to 78.0.3878.1 (7-0-x) Aug 9, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3878.1 (7-0-x) chore: bump chromium to 78.0.3879.1 (7-0-x) Aug 10, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3879.1 (7-0-x) chore: bump chromium to 78.0.3879.2 (7-0-x) Aug 11, 2019
@electron-bot electron-bot changed the title chore: bump chromium to 78.0.3879.2 (7-0-x) chore: bump chromium to 78.0.3880.2 (7-0-x) Aug 12, 2019
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't enabled network service in this branch and we only plan to ship it with 8-0-x, so the non network service code paths shouldn't be removed here.

@deepak1556 deepak1556 dismissed their stale review August 20, 2019 22:08

Network service will be enabled in this branch, since its tracking canary thats deleting more legacy code path https://bugs.chromium.org/p/chromium/issues/detail?id=934009 , will be harder to maintain without the service.

@deepak1556 deepak1556 self-requested a review August 20, 2019 22:08
@deepak1556 deepak1556 self-assigned this Aug 22, 2019
@deepak1556 deepak1556 force-pushed the roller/chromium/7-0-x branch 3 times, most recently from db40d24 to d650fc6 Compare August 29, 2019 00:13
@deepak1556 deepak1556 changed the title chore: bump chromium to 78.0.3880.2 (7-0-x) chore: bump chromium to 78.0.3894.0 (7-0-x) Aug 29, 2019
@deepak1556 deepak1556 changed the title chore: bump chromium to 78.0.3894.0 (7-0-x) chore: bump chromium to 78.0.3896.0 (7-0-x) Aug 29, 2019
deepak1556 and others added 6 commits August 29, 2019 16:06
Co-authored-by: Erick Zhao <erickzhao@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by Micha Hanselmann <DeerMichel@github.com>
…ter) (#19792)

* chore: bump chromium in DEPS to f3bf493731e868e1f5f48e7e1adc02ea5eccfbbd

* chore: bump chromium in DEPS to 4db0c87d4aa6f27ffa0b5fc77d20e10047962484

* chore: bump chromium in DEPS to d933a504c264dc8fe85267f47aef3588531875b5

* chore: bump chromium in DEPS to 34afdb68980f581ae911b85b727bc17e126cf5f9

* update disable-redraw-lock.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1600387

* update desktop_media_list.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1729156

* update notification_provenance.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1742779

* update printing.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1646772

* update verbose_generate_bpad_syms.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1745986

* update patch metadata

* remove printing_compositor manifests

https://chromium-review.googlesource.com/c/chromium/src/+/1742734

* update for URLLoaderFactoryType enum

https://chromium-review.googlesource.com/c/chromium/src/+/1754716

* remove gin string16 converter

https://chromium-review.googlesource.com/c/chromium/src/+/1750093

* ClearCompositorFrame() has been removed

https://chromium-review.googlesource.com/c/chromium/src/+/1746301

* message_loop -> message_loop_current

https://chromium-review.googlesource.com/c/chromium/src/+/1738552

* include resource_response header

* pdf compositor no longer uses service manager

https://chromium-review.googlesource.com/c/chromium/src/+/1742734

* chore: bump chromium in DEPS to 00d5933101d8d8dc9546eadbe7ee1b41077e6db1

* pane focus fns aren't pure virtual anymore

https://chromium-review.googlesource.com/c/chromium/src/+/1708767

* fix: make std::hash value-non-const

broken by https://chromium-review.googlesource.com/c/chromium/src/+/1711202

* update swiftshader in zip_manifests

https://swiftshader-review.googlesource.com/c/SwiftShader/+/34911

* address feedback from @deepak1556

* don't enable kLegacyWindowsDWriteFontFallback

https://chromium-review.googlesource.com/c/chromium/src/+/1753006

* chore: bump chromium in DEPS to 84497314005e1968da06804f8fde539d9872310e

* update printing.patch

remove bottom diff owing to https://chromium-review.googlesource.com/c/chromium/src/+/1678182 and update for https://chromium-review.googlesource.com/c/chromium/src/+/1678182

* convert CookieChangeListener to new Mojo types

https://chromium-review.googlesource.com/c/chromium/src/+/1753371

* rename ui::ClipboardType -> ui::ClipboardBuffer

https://chromium-review.googlesource.com/c/chromium/src/+/1758730

* logging::LoggingSettings log_file -> log_file_path

https://chromium-review.googlesource.com/c/chromium/src/+/1699477

* roll DEPS to latest lkgr

* fix: override GetFontLookupTableCacheDir()

When Chromium goes to use its fallback font table creation code paths,
it creates the cache directory it uses by calling
GetFontLookupTableCacheDir() with a path that doesn't exist in Electron.
To ensure that a legitimate file path is created, we need to override it
with Electron's DIR_USER_DATA so it doesn't use chrome::DIR_USER_DATA.

* chore: bump chromium in DEPS to 6758a0879931bc4df630a80a36c82d7855ae3155

* update pthread_fchdir patch

https://chromium-review.googlesource.com/c/chromium/src/+/1759149

* update printing patch

* update cookie usage and fn signatures

https://chromium-review.googlesource.com/c/chromium/src/+/1758437

* chore: bump chromium in DEPS to bdaca97e1cc27fb977e56f30f74cdb906da9527e

* remove fix_make_std_hash_value-non-const.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1762335

* Convert enum to enum class for FocusManager::FocusChangeReason

https://chromium-review.googlesource.com/c/chromium/src/+/1767281

* roll DEPS to latest lkgr

* update dom_storage_limits.patch

https://chromium-review.googlesource.com/c/chromium/src/+/1767556
)

* refactor: rm IOThread class

* chore: rm expose-net-observer-api.patch

* chore: rm unused shell/browser/net/ classes

* chore: mv CertVerifierClient to separate header

* chore: rm url_request_context_getter references
@deepak1556 deepak1556 requested a review from a team August 30, 2019 00:26
@deepak1556 deepak1556 changed the title chore: bump chromium to 78.0.3896.0 (7-0-x) chore: bump chromium to 78.0.3896.6 (7-0-x) Aug 30, 2019
@jkleinsc jkleinsc merged commit c7a3142 into 7-0-x Aug 30, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 30, 2019

Release Notes Persisted

Updated Chromium to 78.0.3896.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants