Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 63be48daea281d4f8c834c2e707a7 (master) #19923

Merged
merged 61 commits into from
Sep 18, 2019
Merged
Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
77bffcc
chore: bump chromium in DEPS to f2943e7179d7878b4f81d0cc6caa44b3fff3a1e7
electron-bot Aug 24, 2019
19b2c2a
chore: bump chromium in DEPS to 0b1eaa93cee959fa72720bdb21e4489b887b0cae
electron-bot Aug 25, 2019
df64015
chore: bump chromium in DEPS to 5f415c58afc014013f0353e157a3c4e9df0738c7
electron-bot Aug 26, 2019
feab318
chore: bump chromium in DEPS to f62d94b869522b071f76a0e427a48dccf105cebd
electron-bot Aug 27, 2019
bb0ac69
chore: update patches
MarshallOfSound Aug 27, 2019
22cce3c
build: add checkout_openxr=False to DEPS
MarshallOfSound Aug 27, 2019
3955bc3
chore: bump chromium in DEPS to b9241eaad568d5cdb340c76549ae9ea0e24008d3
electron-bot Aug 28, 2019
ed22208
chore: ensure task posters specify an explicit destination
MarshallOfSound Aug 28, 2019
a22b1c8
chore: Revert "Cleanup: Remove Menu Subtitles/Sublabels"
MarshallOfSound Aug 28, 2019
39c187d
chore: update patches for latest chromium roll
MarshallOfSound Aug 28, 2019
54357a6
chore: bump chromium in DEPS to ed172d31ae6914d0631ea72edebff937d5919a0a
electron-bot Aug 29, 2019
f2cf462
chore: handle network::mojom::TrustedHeaderClient refactor
MarshallOfSound Aug 29, 2019
3cbb349
chore: add missing base header for WrapUnique
MarshallOfSound Aug 29, 2019
0388883
chore: update patches
MarshallOfSound Aug 29, 2019
69ec128
Convert TrustedURLLoaderHeaderClient and TrustedHeaderClient to new m…
deepak1556 Aug 29, 2019
f6ca707
skia: more rect api simplifications
deepak1556 Aug 29, 2019
8547b09
chore: rename thread_pool to thread_pool_instance
MarshallOfSound Aug 29, 2019
e633744
Add enterprise policy for renderer CIG.
deepak1556 Aug 29, 2019
81787e0
Convert enum to enum class for Wigdet::FrameType
deepak1556 Aug 29, 2019
6873cfe
chore: bump chromium in DEPS to d987299b2ad885b39b36c1fa7a95f951d7d2ab1e
electron-bot Aug 30, 2019
2849ec5
build: disable widevine cdm component
MarshallOfSound Aug 30, 2019
68706e2
chore: add threadpool target to windows only past tasks
MarshallOfSound Aug 30, 2019
42e500e
chore: bump chromium in DEPS to dee1262470547d154aaa2d0618b1f9428d9c11bd
deepak1556 Sep 9, 2019
47b0b90
chore: update v8 patches
deepak1556 Sep 9, 2019
33e6a06
chore: update chromium patches
deepak1556 Sep 9, 2019
ac5e8db
Convert CertVerifierClient to new Mojo types
deepak1556 Sep 9, 2019
5bedfea
Revert "build: disable widevine cdm component"
deepak1556 Sep 9, 2019
ef0bd66
Require task posters to specify an explicit destination
deepak1556 Aug 28, 2019
e0163b0
Convert Web Speech Synthesis API over to Mojo
deepak1556 Sep 9, 2019
ee5f47f
base: Remove temporary "WithTraits" task API wrappers
deepak1556 Sep 9, 2019
ab2f5ac
CookieInclusionStatus: Support warnings and multiple exclusion reasons
deepak1556 Sep 9, 2019
8611783
Convert DataPipeGetterPtr and DataPipeGetterRequest to new Mojo types
deepak1556 Sep 10, 2019
a768ad2
Remove the typemap from network::mojom::URLResponseHead.
deepak1556 Sep 10, 2019
615d335
ServiceWorker: Make Extension WebRequestAPI aware of service worker u…
deepak1556 Sep 10, 2019
c388f79
FIXME: disable widevine
deepak1556 Sep 10, 2019
acf526b
FIXME: disable osr
deepak1556 Sep 10, 2019
f619514
FIXME: disable net module spec
deepak1556 Sep 10, 2019
d7f9ab4
chore: bump chromium to 538dcb6e7046e5a5dbe9b5b03a10c95242b22b12
deepak1556 Sep 10, 2019
f6ffe6c
Call Dx12/Vulkan info request for about:gpu
deepak1556 Sep 10, 2019
4c6f50b
Revert "FIXME: disable osr"
deepak1556 Sep 10, 2019
a572516
Remove ExternalBeginFrameControllerClient interface
deepak1556 Sep 10, 2019
a17daff
Pass request_unadjusted_movement to lock mouse
deepak1556 Sep 10, 2019
4d8cb7d
build: fix compilation with MSSTL
deepak1556 Sep 10, 2019
0a634c3
build: add CoreGraphics.framework dep for pepper flash
deepak1556 Sep 10, 2019
54e2baf
chore: bump chromium to 8d3cb5b1c439a478a331ba990371d7dc564635e5
deepak1556 Sep 11, 2019
64d5d3f
chore: update chromium patches
deepak1556 Sep 11, 2019
7e0fd96
chore: update v8 patches
deepak1556 Sep 11, 2019
a04b20b
build: Add patches to third_party/perfetto for fixing WoA
deepak1556 Sep 11, 2019
eead4a5
Convert ChunkedDataPipeGetter to new Mojo types
deepak1556 Sep 11, 2019
0144a95
Convert NetworkContextPtr from CreateNetworkContext() to new Mojo types
deepak1556 Sep 11, 2019
8f54541
build: fix compilation with use_jumbo_build on windows
deepak1556 Sep 11, 2019
19b6382
chore: bump chromium to fc1146d0eb232abf9f4083e77dfccbff53f0d93f
deepak1556 Sep 12, 2019
5e08c6d
chore: update chromium patches
deepak1556 Sep 12, 2019
7ae53a1
chore: update v8 patches
deepak1556 Sep 12, 2019
75a7987
Merge remote-tracking branch 'origin/master' into roller/chromium/master
nornagon Sep 17, 2019
6a16b91
bump chromium to af5e1805f244bb71328690460ddd3d48ef3b1eca
nornagon Sep 17, 2019
a1a2b7f
hamstring loginhandler
nornagon Sep 17, 2019
cc24071
initial_size is no longer needed for CreateView
nornagon Sep 17, 2019
f5694a4
remove offscreen+viz patch to fix crashes
nornagon Sep 17, 2019
fbfeafa
disable OSR
nornagon Sep 17, 2019
0db20dd
revert v8 change which broke MSSTL build
nornagon Sep 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ gclient_gn_args = [
'checkout_android_native_support',
'checkout_libaom',
'checkout_nacl',
'checkout_oculus_sdk'
'checkout_oculus_sdk',
'checkout_openxr'
]

vars = {
'chromium_version':
'62327c655093c821aa0fcfc6db53f5fd943e08c7',
'538dcb6e7046e5a5dbe9b5b03a10c95242b22b12',
'node_version':
'v12.9.1',
'nan_version':
Expand Down Expand Up @@ -60,6 +61,8 @@ vars = {
True,
'checkout_oculus_sdk':
False,
'checkout_openxr':
False,
'build_with_chromium':
True,
'checkout_android':
Expand Down
6 changes: 0 additions & 6 deletions chromium_src/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ static_library("chrome") {
sources += [
"//chrome/browser/speech/tts_controller_delegate_impl.cc",
"//chrome/browser/speech/tts_controller_delegate_impl.h",
"//chrome/browser/speech/tts_message_filter.cc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get rid of our tts patch now?

"//chrome/browser/speech/tts_message_filter.h",
"//chrome/renderer/tts_dispatcher.cc",
"//chrome/renderer/tts_dispatcher.h",
]
}

Expand Down Expand Up @@ -202,8 +198,6 @@ static_library("chrome") {
"//chrome/browser/ui/views/overlay/back_to_tab_image_button.h",
"//chrome/browser/ui/views/overlay/close_image_button.cc",
"//chrome/browser/ui/views/overlay/close_image_button.h",
"//chrome/browser/ui/views/overlay/mute_image_button.cc",
"//chrome/browser/ui/views/overlay/mute_image_button.h",
"//chrome/browser/ui/views/overlay/overlay_window_views.cc",
"//chrome/browser/ui/views/overlay/overlay_window_views.h",
"//chrome/browser/ui/views/overlay/playback_image_button.cc",
Expand Down
4 changes: 2 additions & 2 deletions chromium_src/chrome/browser/certificate_manager_model.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ net::NSSCertDatabase* GetNSSCertDatabaseForResourceContext(
void CertificateManagerModel::Create(content::BrowserContext* browser_context,
const CreationCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
base::PostTaskWithTraits(
base::PostTask(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(&CertificateManagerModel::GetCertDBOnIOThread,
browser_context->GetResourceContext(), callback));
Expand Down Expand Up @@ -146,7 +146,7 @@ void CertificateManagerModel::DidGetCertDBOnIOThread(
DCHECK_CURRENTLY_ON(BrowserThread::IO);

bool is_user_db_available = !!cert_db->GetPublicSlot();
base::PostTaskWithTraits(
base::PostTask(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&CertificateManagerModel::DidGetCertDBOnUIThread, cert_db,
is_user_db_available, callback));
Expand Down
9 changes: 4 additions & 5 deletions chromium_src/chrome/browser/process_singleton_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ void ProcessSingleton::LinuxWatcher::SocketReader::FinishWithACK(
if (shutdown(fd_, SHUT_WR) < 0)
PLOG(ERROR) << "shutdown() failed";

base::PostTaskWithTraits(
base::PostTask(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(&ProcessSingleton::LinuxWatcher::RemoveSocketReader,
parent_, this));
Expand Down Expand Up @@ -885,10 +885,9 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessOrCreate() {

void ProcessSingleton::StartListeningOnSocket() {
watcher_ = new LinuxWatcher(this);
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(&ProcessSingleton::LinuxWatcher::StartListening, watcher_,
sock_));
base::PostTask(FROM_HERE, {BrowserThread::IO},
base::BindOnce(&ProcessSingleton::LinuxWatcher::StartListening,
watcher_, sock_));
}

void ProcessSingleton::OnBrowserReady() {
Expand Down
2 changes: 1 addition & 1 deletion patches/chromium/.patches
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ mas-cgdisplayusesforcetogray.patch
mas-audiodeviceduck.patch
mas-lssetapplicationlaunchservicesserverconnectionstatus.patch
ignore_rc_check.patch
enable_widevine.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking issue #20211

chrome_key_systems.patch
allow_nested_error_trackers.patch
blink_initialization_order.patch
Expand Down Expand Up @@ -78,3 +77,4 @@ disable_compositor_recycling.patch
allow_new_privileges_in_unsandboxed_child_processes.patch
expose_setuseragent_on_networkcontext.patch
feat_add_set_theme_source_to_allow_apps_to.patch
revert_cleanup_remove_menu_subtitles_sublabels.patch
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Allows Electron to restore WER when ELECTRON_DEFAULT_ERROR_MODE is set.
This should be upstreamed.

diff --git a/content/gpu/gpu_main.cc b/content/gpu/gpu_main.cc
index 46d92835eadd6429ea0c6a53c5a39ff04f1c2634..1b99a1e601f4226280cdf1382af555b4d61b92fa 100644
index 4373f508964cb1e9fd51c952122ac2f41fb35ae9..065a7a57b77f1e3bf5e03fac900f1936d48ad4ff 100644
--- a/content/gpu/gpu_main.cc
+++ b/content/gpu/gpu_main.cc
@@ -236,6 +236,10 @@ int GpuMain(const MainFunctionParams& parameters) {
Expand Down
6 changes: 3 additions & 3 deletions patches/chromium/add_realloc.patch
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ index 2aef366ac8194aa261cbca6abc051f7da8a988d3..3c7d66c81032636abcca4f1538ce9b7f

GIN_EXPORT static ArrayBufferAllocator* SharedInstance();
diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
index 7ca876bc7f2afa192167f0689690d73d5a420c60..d58085e0b14241d666f533cb23dd89159c27d8b2 100644
index 3eeafca490b1fbbedc2c16f203a4ac28b23da675..fee684296357c2c3af7395bdd17ac8b8445f55c4 100644
--- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
+++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
@@ -642,6 +642,10 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
@@ -647,6 +647,10 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
size, WTF::ArrayBufferContents::kDontInitialize);
}

Expand Down Expand Up @@ -70,7 +70,7 @@ index ac76d127b96b80c8260a7e2cda0b669cd98787ad..dcab64586700a8740262aede8dba2755
Partitions::ArrayBufferPartition()->Free(data);
}
diff --git a/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h b/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h
index ee7c89a4950d6b3c97a810c41a62fee7e372018d..c2b60f20a72cca46d05af369f33d9c19395b34ef 100644
index 3f44cd2fdf648057be8defcf041574b4c91e0363..55c0e7c66649ae9d9cbef6179daac7ad771b755c 100644
--- a/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h
+++ b/third_party/blink/renderer/platform/wtf/typed_arrays/array_buffer_contents.h
@@ -140,6 +140,7 @@ class WTF_EXPORT ArrayBufferContents {
Expand Down
4 changes: 2 additions & 2 deletions patches/chromium/blink_initialization_order.patch
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ to fix electron/electron#13787. The backport landed in Chromium 67 but the
DidCreateScriptContext re-ordering needs to be upstreamed or kept indefinitely

diff --git a/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc b/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc
index c0ec993ca6d96c5f95eb7b918ca9c37d9defff43..2522add8f9b1e3ada14fcc5c09d161b0820f4418 100644
index 8331c466ac9ae91d79c32f17b815f048c7e30a8b..e066abfc3341ff620191116d87ff0e135cdf43e7 100644
--- a/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc
+++ b/third_party/blink/renderer/bindings/core/v8/local_window_proxy.cc
@@ -205,11 +205,10 @@ void LocalWindowProxy::Initialize() {
Expand All @@ -24,5 +24,5 @@ index c0ec993ca6d96c5f95eb7b918ca9c37d9defff43..2522add8f9b1e3ada14fcc5c09d161b0
- InstallConditionalFeatures();
-
// This needs to go after everything else since it accesses the window object.
// WARNING: May modify the global object!
InitializeV8ExtrasBinding(script_state_);

6 changes: 3 additions & 3 deletions patches/chromium/blink_local_frame.patch
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ when there is code doing that.
This patch reverts the change to fix the crash in Electron.

diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc
index 488d9238eec29fd90540881d895f86d8597300be..b9cbd011d8ab5f86128590b2b98a517a5ad04c4e 100644
index 52f56794f2ed1cd027bccf0f1c284b138052fe99..13029678e052af1a6c7a8d0f8655fc9852eedf84 100644
--- a/third_party/blink/renderer/core/frame/local_frame.cc
+++ b/third_party/blink/renderer/core/frame/local_frame.cc
@@ -334,10 +334,6 @@ void LocalFrame::DetachImpl(FrameDetachType type) {
@@ -338,10 +338,6 @@ void LocalFrame::DetachImpl(FrameDetachType type) {
}
CHECK(!view_ || !view_->IsAttached());

Expand All @@ -28,7 +28,7 @@ index 488d9238eec29fd90540881d895f86d8597300be..b9cbd011d8ab5f86128590b2b98a517a
if (!Client())
return;

@@ -355,6 +351,10 @@ void LocalFrame::DetachImpl(FrameDetachType type) {
@@ -359,6 +355,10 @@ void LocalFrame::DetachImpl(FrameDetachType type) {
// Notify ScriptController that the frame is closing, since its cleanup ends
// up calling back to LocalFrameClient via WindowProxy.
GetScriptController().ClearForClose();
Expand Down
4 changes: 2 additions & 2 deletions patches/chromium/blink_world_context.patch
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ index a781a44399a31f048419311d2317229c912752c2..131c0dcb125b00215e3ad469c11c4b47
// that the script evaluated to with callback. Script execution can be
// suspend.
diff --git a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
index 85481bb0178d707bb52a4766521cdd8f740b0497..e3d4e5284c13383db47153adb5f8e3d9fce64dbf 100644
index d1f07949b2049924ca34d07ac9384da6d5f790ad..ad66990c0389ffb5306d2f3c847b78d190d113c0 100644
--- a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
+++ b/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
@@ -874,6 +874,13 @@ v8::Local<v8::Object> WebLocalFrameImpl::GlobalProxy() const {
@@ -877,6 +877,13 @@ v8::Local<v8::Object> WebLocalFrameImpl::GlobalProxy() const {
return MainWorldScriptContext()->Global();
}

Expand Down
4 changes: 2 additions & 2 deletions patches/chromium/build_add_electron_tracing_category.patch
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ categories in use are known / declared. This patch is required for us
to introduce a new Electron category for Electron-specific tracing.

diff --git a/base/trace_event/builtin_categories.h b/base/trace_event/builtin_categories.h
index b50d4123e44ddee34af0b07bfe5d067c4ccc5809..3e2c639a067fb76848783f35ec112a380da2353e 100644
index 6717a2bd93b7bec89934bb3e70cdfb5461dcc29b..ca2bd030d1f46b1a7294883e30274cd0da2e7f49 100644
--- a/base/trace_event/builtin_categories.h
+++ b/base/trace_event/builtin_categories.h
@@ -61,6 +61,7 @@
@@ -62,6 +62,7 @@
X("dwrite") \
X("DXVA Decoding") \
X("EarlyJava") \
Expand Down
6 changes: 3 additions & 3 deletions patches/chromium/build_gn.patch
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Subject: build_gn.patch


diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 59ab7810e71916e8f0f2d69f06e3c2c3ebc99030..b144e800c94956429ca85fc0aefe6539a6246e4b 100644
index f89e7e831b79f82bd11a5dd8cee6ab49d8de724e..f8a611bf0676ce323cdbb5d639333df9875dd0ca 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -123,6 +123,9 @@ if (current_os == "") {
Expand All @@ -18,8 +18,8 @@ index 59ab7810e71916e8f0f2d69f06e3c2c3ebc99030..b144e800c94956429ca85fc0aefe6539
# Set to enable the official build level of optimization. This has nothing
# to do with branding, but enables an additional level of optimization above
# release (!is_debug). This might be better expressed as a tri-state
@@ -437,6 +440,7 @@ default_compiler_configs = [
"//build/config/compiler:thin_archive",
@@ -438,6 +441,7 @@ default_compiler_configs = [
"//build/config/compiler:default_init_stack_vars",
"//build/config/coverage:default_coverage",
"//build/config/sanitizers:default_sanitizer_flags",
+ "//electron/build/config:mas_build",
Expand Down
26 changes: 13 additions & 13 deletions patches/chromium/can_create_window.patch
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ Subject: can_create_window.patch


diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index c6381fe498311421d2568b6d91b33539eb72cb0b..90b2457b49cb9c68a0dd269e8e8f64a44cae80cf 100644
index 21e7f3bf0c6eb2ae005111709ff432505c41fc1f..c59bde04d9cc7e4c974efd244bc4e3718ed1de29 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -3885,6 +3885,7 @@ void RenderFrameHostImpl::CreateNewWindow(
@@ -3977,6 +3977,7 @@ void RenderFrameHostImpl::CreateNewWindow(
last_committed_origin_, params->window_container_type,
params->target_url, params->referrer.To<Referrer>(),
params->frame_name, params->disposition, *params->features,
Expand All @@ -17,10 +17,10 @@ index c6381fe498311421d2568b6d91b33539eb72cb0b..90b2457b49cb9c68a0dd269e8e8f64a4
&no_javascript_access);

diff --git a/content/common/frame.mojom b/content/common/frame.mojom
index e227f780d720a80a13699f475757142571094cd1..6984f69e6f9a0d3058b0054df8a3aa9d46f14dbd 100644
index a99a8f3d7aa9b1fabc6463768b4646b1612cfc72..99e377b69634660db6600b8032601f294142be18 100644
--- a/content/common/frame.mojom
+++ b/content/common/frame.mojom
@@ -299,6 +299,10 @@ struct CreateNewWindowParams {
@@ -307,6 +307,10 @@ struct CreateNewWindowParams {

// The window features to use for the new window.
blink.mojom.WindowFeatures features;
Expand All @@ -32,10 +32,10 @@ index e227f780d720a80a13699f475757142571094cd1..6984f69e6f9a0d3058b0054df8a3aa9d

// Operation result when the renderer asks the browser to create a new window.
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index 1c904cd011b7a5ca9592a994cf4ba0be025eef55..15081967b0a29316ab82746ca6fe7d188a9efc58 100644
index 3e5ebb5c71ba2b6a3cc0f914e10c64dce06d6088..d51d21fbd09cfa2c017f85ab96c1156a6a4f74f9 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -484,6 +484,8 @@ bool ContentBrowserClient::CanCreateWindow(
@@ -489,6 +489,8 @@ bool ContentBrowserClient::CanCreateWindow(
const std::string& frame_name,
WindowOpenDisposition disposition,
const blink::mojom::WindowFeatures& features,
Expand All @@ -45,7 +45,7 @@ index 1c904cd011b7a5ca9592a994cf4ba0be025eef55..15081967b0a29316ab82746ca6fe7d18
bool opener_suppressed,
bool* no_javascript_access) {
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 07dc81e27ae92e4e7a872134dcdc6a3ba2e08ec5..678b25401338a624dc37a11c45331d65082934e9 100644
index dcb77c78114699a0017a305f140f4322d271ff83..aeb22701d036c54cb495540847e333b380350e8a 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -178,6 +178,7 @@ class RenderFrameHost;
Expand All @@ -56,7 +56,7 @@ index 07dc81e27ae92e4e7a872134dcdc6a3ba2e08ec5..678b25401338a624dc37a11c45331d65
class SerialDelegate;
class SiteInstance;
class SpeechRecognitionManagerDelegate;
@@ -767,6 +768,8 @@ class CONTENT_EXPORT ContentBrowserClient {
@@ -771,6 +772,8 @@ class CONTENT_EXPORT ContentBrowserClient {
const std::string& frame_name,
WindowOpenDisposition disposition,
const blink::mojom::WindowFeatures& features,
Expand All @@ -66,18 +66,18 @@ index 07dc81e27ae92e4e7a872134dcdc6a3ba2e08ec5..678b25401338a624dc37a11c45331d65
bool opener_suppressed,
bool* no_javascript_access);
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index a8a2d29739aabb0bd80cb77e28c46de57afe2b10..e3fa35b439e0f945e9e6a95587561fedd1ef4a2c 100644
index 36012ef78a9ef8747087848e69a853df02243659..21ef572e00cdbf89e0439dbd5f6409cf1251ea0c 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -75,6 +75,7 @@
@@ -73,6 +73,7 @@
#include "content/renderer/ime_event_guard.h"
#include "content/renderer/internal_document_state_data.h"
#include "content/renderer/loader/request_extra_data.h"
+#include "content/renderer/loader/web_url_request_util.h"
#include "content/renderer/media/audio/audio_device_factory.h"
#include "content/renderer/media/webrtc/peer_connection_dependency_factory.h"
#include "content/renderer/media/webrtc/rtc_peer_connection_handler.h"
@@ -1346,6 +1347,8 @@ WebView* RenderViewImpl::CreateView(
@@ -1322,6 +1323,8 @@ WebView* RenderViewImpl::CreateView(
}
params->features = ConvertWebWindowFeaturesToMojoWindowFeatures(features);

Expand All @@ -87,10 +87,10 @@ index a8a2d29739aabb0bd80cb77e28c46de57afe2b10..e3fa35b439e0f945e9e6a95587561fed
// moved on send.
bool is_background_tab =
diff --git a/content/shell/browser/web_test/web_test_content_browser_client.cc b/content/shell/browser/web_test/web_test_content_browser_client.cc
index 1a159e8d2877e5b1c6778b68aec5b36fb88214fd..f9111b3e20fb7607faa4bb605be1ff4c385e40d6 100644
index e0e6f185c567ccf96c9a4d1b62bc6b060d0d3c0c..55685e60c431d3f39edeb415cafd7070de57c746 100644
--- a/content/shell/browser/web_test/web_test_content_browser_client.cc
+++ b/content/shell/browser/web_test/web_test_content_browser_client.cc
@@ -313,6 +313,8 @@ bool WebTestContentBrowserClient::CanCreateWindow(
@@ -312,6 +312,8 @@ bool WebTestContentBrowserClient::CanCreateWindow(
const std::string& frame_name,
WindowOpenDisposition disposition,
const blink::mojom::WindowFeatures& features,
Expand Down
4 changes: 2 additions & 2 deletions patches/chromium/content_browser_main_loop.patch
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ run before shutdown. This is required to cleanup WebContents asynchronously
in atom::CommonWebContentsDelegate::ResetManageWebContents.

diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index 61324582c2dca5e1e5a75c0793034307b648cc98..c73c1e26c2f01713952840fadbd7e8975bcb9843 100644
index 3f0931ad906f4a3431ab78c9a11eaf7e32cbdebb..6da438a20802e290d5c3ef5593e2c1eed2b0db5f 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -1496,7 +1496,7 @@ void BrowserMainLoop::MainMessageLoopRun() {
@@ -1505,7 +1505,7 @@ void BrowserMainLoop::MainMessageLoopRun() {
NOTREACHED();
#else
base::RunLoop run_loop;
Expand Down
6 changes: 3 additions & 3 deletions patches/chromium/dcheck.patch
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ only one or two specific checks fail. Then it's better to simply comment out the
failing checks and allow the rest of the target to have them enabled.

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 4bc8bd4c68015dd684702a6afbce74b36160e5a1..55dc200a73ef09b17c0e52d622f86956ba6a7bb7 100644
index 3f207fcfce857692febe79df7b9ba4afb594270d..fe40d01779685ab86d5ddb3e4f5193ad89305f87 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1210,8 +1210,10 @@ NavigationType NavigationControllerImpl::ClassifyNavigation(
Expand Down Expand Up @@ -46,10 +46,10 @@ index 4bc8bd4c68015dd684702a6afbce74b36160e5a1..55dc200a73ef09b17c0e52d622f86956
// navigation. Now we know that the renderer has updated its state accordingly
// and it is safe to also clear the browser side history.
diff --git a/ui/base/clipboard/clipboard_win.cc b/ui/base/clipboard/clipboard_win.cc
index 87a82009c929ff73d3d9fe5b51907b9b4147f78f..32d2316d7553b672a28e84f9433c85d1be213623 100644
index 34c13c28117fe5fced5ca3190c5f948168cd010f..554ddabee8952e578a61a9b9c3f358b2475abd69 100644
--- a/ui/base/clipboard/clipboard_win.cc
+++ b/ui/base/clipboard/clipboard_win.cc
@@ -729,9 +729,9 @@ void ClipboardWin::WriteBitmapFromHandle(HBITMAP source_hbitmap,
@@ -730,9 +730,9 @@ void ClipboardWin::WriteBitmapFromHandle(HBITMAP source_hbitmap,
}

void ClipboardWin::WriteToClipboard(unsigned int format, HANDLE handle) {
Expand Down
Loading