Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that the "top" coordinate of the inner frame is correct #20052

Conversation

@trop
Copy link
Contributor

commented Aug 30, 2019

Backport of #20051

See that PR for details.

Notes: Fixed issue where maximizing a window on Windows in vertically stacked multi-monitor setups could result in the window rendering a white screen.

fix: ensure that the "top" coordinate of the inner frame is correct
On multi-monitor setups where the monitors are not all origined at 0 on
the Y coordinate (E.g. vertical stacked monitors) the maximize
calculation was incorrect as it assumed top was "0".  This instead
adjusts the math to calculate the correct top value.

@MarshallOfSound MarshallOfSound merged commit ed7ae42 into 6-0-x Aug 30, 2019

13 of 14 checks passed

build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190830.44 succeeded
Details
electron-arm64-testing Build #20190830.44 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 30, 2019

Release Notes Persisted

Fixed issue where maximizing a window on Windows in vertically stacked multi-monitor setups could result in the window rendering a white screen.

@MarshallOfSound MarshallOfSound deleted the trop/6-0-x-bp-fix-ensure-that-the-top-coordinate-of-the-inner-frame-is-correct-1567205172093 branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.